Skip to content

Conversation

@leegwichan
Copy link
Member

@leegwichan leegwichan commented Jul 24, 2025

✨ 개요

  • 가게 상세 정보 조회 API 구현
  • 자세한 사항은 이슈 참고해주세요!

🧾 관련 이슈

closed #97

🔍 참고 사항 (선택)

  • 이미지는 다른 API를 통해 제공

Summary by CodeRabbit

  • 신규 기능

    • 특정 음식점의 상세 정보를 조회할 수 있는 API 엔드포인트(/api/shops/{storeId})가 추가되었습니다.
    • 음식점 상세 정보 응답에 ID, 카카오ID, 이름, 행정구, 동네, 카테고리, 장소 URL이 포함됩니다.
  • 테스트

    • 음식점 상세 조회 기능에 대한 컨트롤러, 서비스, API 문서 테스트가 추가되었습니다.
    • 음식점이 존재하지 않을 때의 예외 처리 테스트가 포함되었습니다.
  • 문서화

    • 음식점 상세 조회 API에 대한 문서가 추가 및 개선되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Jul 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

가게 상세 정보를 조회하는 새로운 GET API 엔드포인트(/api/shops/{storeId})가 추가되었습니다. 이를 위해 컨트롤러, 서비스, 레포지토리, DTO(레코드) 계층이 확장되었으며, 관련 테스트 및 문서화 테스트가 포함되었습니다. 예외 처리 및 응답 구조도 명확히 구현되었습니다.

Changes

파일/경로 요약 변경 내용 요약
src/main/java/eatda/controller/store/StoreController.java /api/shops/{storeId} GET 엔드포인트 및 관련 메서드 추가, PathVariable import 추가
src/main/java/eatda/controller/store/StoreResponse.java StoreResponse 레코드 및 Store 기반 생성자 추가
src/main/java/eatda/repository/store/StoreRepository.java JpaRepository 상속, save 메서드 제거, getById(Long id) 기본 구현(예외 처리 포함) 추가
src/main/java/eatda/service/store/StoreService.java getStore(long storeId) 서비스 메서드 추가
src/test/java/eatda/controller/store/StoreControllerTest.java GetStore 중첩 테스트 클래스 및 상세 조회 테스트 메서드 추가
src/test/java/eatda/document/store/StoreDocumentTest.java GetStore 중첩 테스트 클래스 및 API 문서화 테스트 추가, 기존 GetStores 문서명 일관성 수정
src/test/java/eatda/service/store/StoreServiceTest.java GetStore 중첩 테스트 클래스 및 정상/예외 케이스 테스트 메서드 추가
src/main/resources/application-dev.yml CORS origin 설정에서 URL 변경 (https://api-dev.eatda.nethttps://dev.eatda.net)

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant StoreController
    participant StoreService
    participant StoreRepository

    Client->>StoreController: GET /api/shops/{storeId}
    StoreController->>StoreService: getStore(storeId)
    StoreService->>StoreRepository: getById(storeId)
    StoreRepository-->>StoreService: Store or Exception
    StoreService-->>StoreController: StoreResponse
    StoreController-->>Client: HTTP 200 + StoreResponse
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

Suggested labels

released on @beta

Suggested reviewers

  • lvalentine6

Poem

🐰
가게 정보를 찾아서, hop hop hop!
상세한 응답으로 깡총깡총 점프,
테스트와 문서도 꼼꼼하게 챙겼지,
예외도 놓치지 않고 딱!
리뷰어도 미소 짓는 오늘,
새로운 API와 함께
토끼는 기쁘게 춤춘다!
🥕

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89fad84 and 8fdfe16.

📒 Files selected for processing (1)
  • src/main/resources/application-dev.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/PRODUCT-196

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@lvalentine6 lvalentine6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 PR도 고생하셨습니다! 🎉
LGTM입니다!!

@leegwichan leegwichan merged commit aee2827 into develop Jul 26, 2025
2 of 3 checks passed
@leegwichan leegwichan deleted the feat/PRODUCT-196 branch July 26, 2025 08:53
@github-actions
Copy link

🎉 This PR is included in version 1.4.0-develop.30 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PRODUCT-196] [Feat] 가게 상세 정보 조회 API 구현

3 participants