[Fix] 스토리 본문 내용 NULL 허용 #120

leegwichan · 2025-07-28T01:24:35Z

✨ 개요

Story 설명에 description의 null을 허용하도록 함

🧾 관련 이슈

closed #119

🔍 참고 사항 (선택)

DEV 카톡방 참고해주세요!

Summary by CodeRabbit

버그 수정
- 스토리 설명이 null일 경우 더 이상 예외가 발생하지 않도록 검증 로직이 변경되었습니다.
- 빈 문자열("") 설명에 대해서만 예외가 발생하도록 수정되었습니다.
- 관련 오류 메시지가 "스토리 본문은 빈 문자열일 수 없습니다."로 변경되었습니다.
테스트
- 스토리 설명이 null인 경우 예외가 발생하지 않는지 확인하는 테스트가 추가되었습니다.
- 이미지 키가 비어 있을 때 예외가 발생하는지 확인하는 테스트가 추가되었습니다.
- 빈 문자열 설명에 대한 테스트가 명확하게 분리되었습니다.
문서
- 스토리 등록 API 요청의 설명 필드가 선택 사항임을 명확히 표시하도록 문서가 업데이트되었습니다.
- 가게 등록 응원 API 요청의 필수 필드에 대한 주석이 추가되어 명확성이 향상되었습니다.

coderabbitai · 2025-07-28T01:24:41Z

Caution

Review failed

The pull request is closed.

"""

Walkthrough

스토리 본문(description) 검증 로직이 수정되어, 이제 description이 null일 경우 예외를 발생시키지 않습니다. 관련 에러 메시지도 "필수"에서 "빈 문자열 불가"로 변경되었습니다. 테스트 코드에는 null 허용 및 빈 문자열 예외 상황을 명확히 검증하는 테스트가 추가 및 수정되었습니다.

Changes

Cohort	파일 목록	변경 요약
스토리 본문 검증 로직	`src/main/java/eatda/domain/story/Story.java`	description이 null일 때 예외를 발생시키지 않도록 검증 로직 수정
에러 메시지 변경	`src/main/java/eatda/exception/BusinessErrorCode.java`	INVALID_STORY_DESCRIPTION 메시지를 "필수"에서 "빈 문자열 불가"로 수정
테스트 코드 보강	`src/test/java/eatda/domain/story/StoryTest.java`	null 허용 테스트 추가, 빈 문자열 테스트 명확화, ImageKey 검증 테스트 추가
API 문서 주석 수정	`src/test/java/eatda/document/store/CheerDocumentTest.java`, `src/test/java/eatda/document/story/StoryDocumentTest.java`	API 요청 예시 주석에 필수/nullable 명시, request body 필드 설명 변경

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
스토리 본문 내용에 NULL 허용 (#119)	✅

Assessment against linked issues: Out-of-scope changes

Code Change	Explanation
API 문서 주석 및 필드 설명 변경 (`src/test/java/eatda/document/store/CheerDocumentTest.java`, `src/test/java/eatda/document/story/StoryDocumentTest.java`)	문서 주석 및 필드 설명 변경은 #119 이슈의 스토리 본문 null 허용과 직접 관련이 없으며, 문서 가독성 향상 목적의 부수적 변경임

Poem

🐰
스토리 본문, 이제 null도 괜찮아
빈 문자열만 아니면 모두가 환영이야!
에러 메시지도 살짝 고치고
테스트 토끼도 신나게 뛰놀아
코드가 더 유연해진 오늘,
한입에 당근 케이크 한 조각!
🌱
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a644eea and 449d315.

📒 Files selected for processing (2)

src/test/java/eatda/document/store/CheerDocumentTest.java (1 hunks)
src/test/java/eatda/document/story/StoryDocumentTest.java (2 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/PRODUCT-212

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

lvalentine6

이번 PR도 고생하셨습니다! 🦖
LGTM!

sonarqubecloud · 2025-07-28T11:39:16Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-28T11:39:44Z

🎉 This PR is included in version 1.4.0-develop.32 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions · 2025-07-31T13:50:18Z

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

leegwichan added 2 commits July 28, 2025 10:22

fix: Story 의 설명 null 허용

7c23255

test: Story 의 이미지 테스트 케이스 추가

a644eea

github-actions bot requested a review from lvalentine6 July 28, 2025 01:24

github-actions bot added the fix label Jul 28, 2025

github-actions bot assigned leegwichan Jul 28, 2025

leegwichan changed the title ~~Fix/product 212~~ [Fix] 스토리 본문 내용 NULL 허용 Jul 28, 2025

lvalentine6 approved these changes Jul 28, 2025

View reviewed changes

docs: 응원, 스토리 등록 문서 일부 추가

449d315

leegwichan merged commit 1318cfe into develop Jul 28, 2025
2 of 3 checks passed

leegwichan deleted the fix/PRODUCT-212 branch July 28, 2025 11:38

github-actions bot added the released on @beta label Jul 28, 2025

github-actions bot added the released label Jul 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Fix] 스토리 본문 내용 NULL 허용 #120

[Fix] 스토리 본문 내용 NULL 허용 #120

Uh oh!

leegwichan commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

lvalentine6 left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Fix] 스토리 본문 내용 NULL 허용 #120

[Fix] 스토리 본문 내용 NULL 허용 #120

Uh oh!

Conversation

leegwichan commented Jul 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ 개요

🧾 관련 이슈

🔍 참고 사항 (선택)

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

lvalentine6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 28, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leegwichan commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading