-
Notifications
You must be signed in to change notification settings - Fork 0
[YS-505] feature: 공고 수정 - 기존 공고 조회 시, 누락되었던 isOnCampus 필드값 추가 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
07d3004
feat: add isOnCampus field to create new experiment posts
chock-cho 1e7283d
feat: add isOnCampus field in ExperimentPostEntity
chock-cho c6b7ec3
feat: add isOnCampus value on presentation layer
chock-cho 2aaf346
fix: fix failed test cases
chock-cho 9f52042
feat: revise isOnCampus field nullable to non-nullable
chock-cho 0e26473
feature: add isOnCampus field in updateExperimentPost
chock-cho 02b8a9b
feature: add isOnCampus field in GET /{postId}/edit
chock-cho 8e8d0e7
feature: add isOnCampus in AddressResponse
chock-cho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ data class UpdateExperimentPostRequest( | |
|
|
||
| val leadResearcher: String?, // 연구 책임 정보 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능 | ||
|
|
||
| val isOnCampus: Boolean, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update 요청 스키마의 비호환 변경 위험 isOnCampus를 필수(Boolean)로 추가하면 기존 클라이언트 요청이 400으로 깨질 수 있습니다. 하위 호환을 위해 nullable+기본값 또는 기본값만 두는 것을 권장합니다. 업데이트 로직에서는 null이면 기존 값을 유지하는 패치 동작으로 처리하세요. 적용 예시: - val isOnCampus: Boolean,
+ val isOnCampus: Boolean? = null,업데이트 적용 시(참고용): // 예: usecase/mapper 내부
val newIsOnCampus = request.isOnCampus ?: existing.isOnCampus🤖 Prompt for AI Agents |
||
| val place: String?, // 대학교 이름 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능 | ||
| val region: Region?, | ||
| val area: Area?, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isOnCampus 업데이트 미반영(기능 오류)
Input에 추가된
isOnCampus가 도메인 업데이트 경로로 전달되지 않아 값 변경이 저장/반영되지 않습니다. 응답(PostInfo)에서는updatedPost.isOnCampus를 노출하므로, 사용자는 업데이트가 되지 않은 값(이전 값)을 보게 됩니다.아래와 같이 UseCase에서 도메인
update호출 시 인자를 추가하고, 도메인 모델의update시그니처/복사에도 필드를 반영해 주세요(도메인 파일의 수정 제안은 해당 파일 코멘트에 첨부).val experimentPost = existingPost.update( applyMethod = applyMethod, targetGroup = targetGroup, title = input.title, reward = input.reward, startDate = input.startDate, endDate = input.endDate, content = input.content, count = input.count, leadResearcher = input.leadResearcher, detailedAddress = input.detailedAddress, matchType = input.matchType, + isOnCampus = input.isOnCampus, place = input.place, region = input.region, area = input.area, timeRequired = input.timeRequired, imageListInfo = input.imageListInfo?.images, recruitStatus = input.recruitStatus, idGenerator = idGenerator )Also applies to: 100-119, 127-127