[REFACTOR] 1.0.0 릴리즈 버전 QA를 진행합니다. #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Mar 7, 2025
| val userId = userPreferences.userIdFlow.firstOrNull() | ||
| if (userId != null) { | ||
| fetchUserInfo(userId) | ||
| updateState { copy(shouldFetchUserInfo = true) } |
Member
There was a problem hiding this comment.
[p3]
여기서 shouldFetchUserInfo 를 true로 해주는 이유가 뭔가요??
Member
Author
There was a problem hiding this comment.
앗 이전에 Setting->EditProfile에서 항상 fetch를 하지 않는 문제 때문에 넣어둔 코드 같습니다.
지금은 구조를 바꾸면서 shouldFetchUserInfo = true가 보장되니 제거해도 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #185
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢