[FEAT] 알람 해제 - 미션 시작 UX 흐름을 간소화합니다. #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
requested changes
Apr 24, 2025
Member
DongChyeon
left a comment
DongChyeon
left a comment
There was a problem hiding this comment.
미션이 있을 때만 미션 시작이라고 표시해야 하는데
미션 시작을 판단하는 로직이 core:alarm 모듈에 servcie랑 receiver에 있어
그래서 혹시 모르는 거 있으면 물어봐
|
|
||
| OrbitButton( | ||
| label = stringResource(id = R.string.alarm_off_btn), | ||
| label = stringResource(id = R.string.alarm_off_mission_start_btn), |
Member
There was a problem hiding this comment.
[p0]
이거 미션 수행할 때만 미션 시작 이고 나머지는 알람 해제 그대로 유지해야해
- 가독성 향상을 위한 함수 분리 - 각 컴포저블 함수에 간단한 Kdoc주석 추가
MoonsuKang
force-pushed
the
feat/#215-streamline-mission
branch
from
d7e0cf2 to
45efedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #215
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
MissionProgressScreen과MissionScreen을 하나로 병합했습니다.-Composable 함수 구조를 정리하고, 각 함수 위에 간단한 KDoc 주석을 추가했습니다.
Uncompleted Tasks 😅
To Reviewers 📢
SHOOT