-
Notifications
You must be signed in to change notification settings - Fork 1
[REFACTOR] 네비게이션의 sealed class 기반 경로를 KClass 기반으로 리팩토링 #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonsuKang
reviewed
Jun 7, 2025
Member
MoonsuKang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core/common/src/main/java/com/yapp/common/navigation/extensions/RouteExtension.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
@MoonsuKang 수정했으요 |
MoonsuKang
approved these changes
Jun 8, 2025
Member
MoonsuKang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Related issue 🛠
closed #212
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
navigateTo 함수를 라우트별 명시적 라우팅 함수로 분리해당 함수로 변환해서 사용하려 했지만...
KClass는 기본적으로 직렬화가 불가능하기 때문에 해당 오류를 접했습니다...
따라서
다음과 같이 라우트별로 명시적으로 이동하는 함수로 분리했습니다.
navigation( route = AlarmInteractionDestination.Route.route, startDestination = "${AlarmInteractionDestination.AlarmAction.route}/{alarm}", )기존에 String 기반 라우팅을 하면 startDestination에 alarm을 인자로 넘길 수 있는 반면
KClass 기반 라우팅으로 변경할 시 startDestination에 Alarm을 넘겨줄 수 없기 때문에
첫 화면인
AlarmDestination.Route에서 화면 이동 분기 처리를 했습니다.Uncompleted Tasks 😅
To Reviewers 📢
분량 테러 미안합니다!!!