Skip to content

feat: Design 컴포넌트 추가 및 코드 스타일 개선 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seoyoon513 merged 9 commits into from
Jul 10, 2025
Merged

feat: Design 컴포넌트 추가 및 코드 스타일 개선 #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2db6686
[BOOK-123] refactor: ReedButton 파라미터 순서 변경
seoyoon513 Jul 10, 2025
03a19df
[BOOK-123] feat: ButtonSizeStyle에 iconSize 추가
seoyoon513 Jul 10, 2025
fce30b3
[BOOK-123] feat: ButtonSizeStyle에 RoundedButton 스타일 추가
seoyoon513 Jul 10, 2025
8f52ef0
[BOOK-123] refactor: ReedButton Preview 개선
seoyoon513 Jul 10, 2025
45da0ec
[BOOK-123] refactor: ReedTopAppBar 코드 스타일 개선
seoyoon513 Jul 10, 2025
ab3d905
[BOOK-123] refactor: checkbox 코드 스타일 개선
seoyoon513 Jul 10, 2025
f5e9dfc
[BOOK-123] refactor: ReedBottomSheet 코드 스타일 개선
seoyoon513 Jul 10, 2025
69f594d
[BOOK-123] refactor: Screen에서 쓰는 ReedButton 파라미터 순서 변경
seoyoon513 Jul 10, 2025
3e1ac21
[BOOK-123] chore: code style check success
seoyoon513 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...c/main/kotlin/com/ninecraft/booket/core/designsystem/component/checkbox/CircleCheckBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.vectorResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.ninecraft.booket.core.common.extensions.noRippleClickable
Expand Down Expand Up @@ -45,7 +47,7 @@ fun CircleCheckBox(
contentAlignment = Alignment.Center,
) {
Icon(
painter = painterResource(id = R.drawable.ic_check),
imageVector = ImageVector.vectorResource(id = R.drawable.ic_check),
Copy link
Contributor

@easyhooon easyhooon Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

contentDescription = "Circle Checkbox",
tint = iconTint,
)
Expand Down
4 changes: 3 additions & 1 deletion ...c/main/kotlin/com/ninecraft/booket/core/designsystem/component/checkbox/SquareCheckBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.vectorResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.ninecraft.booket.core.common.extensions.noRippleClickable
Expand Down Expand Up @@ -45,7 +47,7 @@ fun SquareCheckBox(
contentAlignment = Alignment.Center,
) {
Icon(
painter = painterResource(id = R.drawable.ic_check),
imageVector = ImageVector.vectorResource(id = R.drawable.ic_check),
contentDescription = "Square Checkbox",
tint = iconTint,
)
Expand Down
6 changes: 4 additions & 2 deletions ...main/kotlin/com/ninecraft/booket/core/designsystem/component/checkbox/TickOnlyCheckBox.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.vectorResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.ninecraft.booket.core.common.extensions.noRippleClickable
Expand All @@ -23,11 +25,11 @@ fun TickOnlyCheckBox(
modifier: Modifier = Modifier,
) {
Icon(
imageVector = ImageVector.vectorResource(id = R.drawable.ic_check),
contentDescription = "TickOnly Checkbox",
modifier = modifier
.size(24.dp)
.noRippleClickable { onCheckedChange(!checked) },
painter = painterResource(id = R.drawable.ic_check),
contentDescription = "TickOnly Checkbox",
tint = if (checked) ReedTheme.colors.contentBrand else ReedTheme.colors.contentTertiary,
)
}
Expand Down