-
Notifications
You must be signed in to change notification settings - Fork 1
feat: 도서 등록 및 도서 목록 조회 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0c66457
[BOOK-96] feat: infra - UserBookEntity 구현 (#29)
minwoo1999 e36fcf9
[BOOK-96] feat: infra - UserBookRepository 구현 (#29)
minwoo1999 374356d
[BOOK-96] refactor: infra - UserBookEntity 수정 (#29)
minwoo1999 7be19e0
[BOOK-96] feat: domain - book,userbook domainservice 분리 (#29)
minwoo1999 8ac5039
[BOOK-96] feat: domain - UserBook Domain 모델 구현 (#29)
minwoo1999 d0722ff
[BOOK-96] refactor: domain - Book Domain 모델 수정 (#29)
minwoo1999 a0882aa
[BOOK-96] feat: apis - 도서등록,내서재 Usecase 구현 (#29)
minwoo1999 7241fdb
[BOOK-96] feat: apis - Book Exception 정의 (#29)
minwoo1999 e63d655
[BOOK-96] feat: apis - UserBook Dto 구현 (#29)
minwoo1999 cbced98
[BOOK-96] refactor: apis - BookDetail DTO 수정 (#29)
minwoo1999 5cc8b78
[BOOK-96] feat: apis - Controller 도서등록, 내서재 구현 (#29)
minwoo1999 352a221
[BOOK-96] chore: infra,domain,apis import * 제거
minwoo1999 d635d9f
[BOOK-96] refator: infra - 상태 변경이 필요한 필드를 var + protected set (#29)
minwoo1999 1077b85
[BOOK-96] feat: domain - userBook 도메인계층 기능개발 (#29)
minwoo1999 ea6f796
[BOOK-96] refactor: apis - service계층 분리 (#29)
minwoo1999 e744548
[BOOK-96] feat: apis - dto 정의 (#29)
minwoo1999 8772208
[BOOK-96] refactor: apis - usecase service 분리 (#29)
minwoo1999 d70529f
[BOOK-96] refactor: apis - AuthenticationPrincipal를 통해 userId 주입 …
minwoo1999 31b643c
[BOOK-96] refactor: apis - api swagger 명세서 response 수정
minwoo1999 3be48ab
[BOOK-96] refactor: apis,domain,infra - user validate 메소드 별도로 분리
minwoo1999 753d309
[BOOK-96] chore: apis - 불필요한 코드 제거 (#29)
minwoo1999 2931e91
[BOOK-96] refactor: apis,domain - 패키지구조 변경 (#29)
minwoo1999 e66845a
[BOOK-96] refactor: apis- 패키지구조 변경 (#29)
minwoo1999 91d69cf
[BOOK-96] refactor: apis- 외부 API 인터페이스 추상화 (#29)
minwoo1999 3911657
[BOOK-96] refactor: apis- book도메인 객체 domainservice 내부에서 생성 (#29)
minwoo1999 c1cfc11
[BOOK-96] refactor: apis- BookQueryServiceQualifier 상수처리 (#29)
minwoo1999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
apis/src/main/kotlin/org/yapp/apis/auth/dto/response/UserProfileResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
apis/src/main/kotlin/org/yapp/apis/book/constant/BookQueryServiceQualifier.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package org.yapp.apis.book.constant | ||
|
|
||
| object BookQueryServiceQualifier { | ||
| const val ALADIN = "aladinBookQueryService" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
문자열 Qualifier 대신 전용 애노테이션 고려
상수 문자열로 Qualifier 를 관리하면 오타로 인한 런타임 오류 가능성이 남아 있습니다.
전용 애노테이션을 정의하면 컴파일타임 안전성을 확보할 수 있으니 검토해 보세요.
서비스/주입부에서는
@AladinBookQuery로 대체하면 됩니다.📝 Committable suggestion
🤖 Prompt for AI Agents