-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: 모든 ISBN 사용 로직을 ISBN13을 사용하도록 변경 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9f7ea9b
[BOOK-235] refactor: 모든 ISBN 사용 로직을 ISBN13을 사용하도록 변경
move-hoon f097d52
[BOOK-235] fix: infra - 칼럼 이름 필드명이랑 통일
move-hoon 3bb5b25
[BOOK-235] refactor: apis, domain - 코드레빗 리뷰 반영
move-hoon b1ad3e2
[BOOK-235] chore: apis - UserBooksByIsbn13sRequest DTO의 설명을 ISBN13으로 수정
move-hoon f9df643
[BOOK-235] refactor: global-utils - ISBN 유효성 검사 메서드를 ISBN10과 ISBN13으로 분리
move-hoon 08d9473
[BOOK-235] refactor: domain - ISBN 유효성 검사 메서드를 ISBN13으로 변경
move-hoon 272d036
[BOOK-235] refactor: apis - ISBN 유효성 검사 로직을 별도의 메서드로 분리하여 가독성 향상
move-hoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
apis/src/main/kotlin/org/yapp/apis/book/service/BookQueryService.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| package org.yapp.apis.book.service | ||
|
|
||
| import jakarta.validation.Valid | ||
| import org.yapp.apis.book.dto.request.BookDetailRequest | ||
| import org.yapp.apis.book.dto.request.BookSearchRequest | ||
| import org.yapp.apis.book.dto.response.BookDetailResponse | ||
| import org.yapp.apis.book.dto.response.BookSearchResponse | ||
|
|
||
| sealed interface BookQueryService { | ||
| fun searchBooks(request: BookSearchRequest): BookSearchResponse | ||
| fun getBookDetail(@Valid request: BookDetailRequest): BookDetailResponse | ||
| fun getBookDetail(request: BookDetailRequest): BookDetailResponse | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
검증 메시지 용어 일관성을 개선해주세요.
검증 메시지가 "isbn13 리스트"로 되어 있지만, 실제 프로퍼티명은
isbn13s입니다. 일관성을 위해 메시지를 프로퍼티명과 맞춰주세요.다음과 같이 수정을 제안합니다:
📝 Committable suggestion
🤖 Prompt for AI Agents