chore: CI/CD 워크플로우 완료 시 Discord 웹훅을 통한 알림 전송 기능 개발 #86
Conversation
|
Warning Rate limit exceeded@hoonyworld has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughGitHub Actions 워크플로우 파일에 두 개의 신규 단계가 추가되었습니다. 빌드 및 배포 작업이 성공하거나 실패할 때 각각 Discord 웹훅을 통해 알림을 전송하는 단계가 조건부로 실행되도록 설정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Discord Webhook
GitHub Actions->GitHub Actions: build, push, deploy steps
alt 성공 시
GitHub Actions->Discord Webhook: 성공 알림 전송 (commit 정보 포함)
else 실패 시
GitHub Actions->Discord Webhook: 실패 알림 전송 (commit 정보 및 실패 메시지 포함)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(해당 사항 없음) ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/dev-ci-cd.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/dev-ci-cd.yml
[error] 106-106: trailing spaces
(trailing-spaces)
| - name: Send Discord notification on failure | ||
| uses: tsickert/[email protected] | ||
| if: failure() | ||
| with: | ||
| webhook-url: ${{ secrets.DEV_DEPLOY_DISCORD_WEBHOOK_URL }} | ||
| embed-title: "❌ [${{ github.repository }}] Development Deploy Failed" | ||
| embed-description: | | ||
| **Commit**: `${{ github.sha }}` | ||
| **Author**: `${{ github.actor }}` | ||
| An error occurred during the workflow execution. | ||
| [View Failed Workflow](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}) | ||
| embed-color: 16711680 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
실패 알림 단계도 동일하게 방어 코드 추가 필요
배포가 실패한 상황에서는 알림 전송까지 실패하더라도 추가 정보가 사라질 뿐입니다. 알림 실패로 인해 로그가 더 복잡해지지 않도록 continue-on-error: true 를 넣고, 성공 단계와 마찬가지로 커밋 메시지 표시를 추가하면 원인 파악이 수월해집니다.
- name: Send Discord notification on failure
uses: tsickert/[email protected]
if: failure()
+ continue-on-error: true
with:
webhook-url: ${{ secrets.DEV_DEPLOY_DISCORD_WEBHOOK_URL }}
embed-title: "❌ [${{ github.repository }}] Development Deploy Failed"
embed-description: |
**Commit**: `${{ github.sha }}`
**Author**: `${{ github.actor }}`
+ **Message**: `${{ github.event.head_commit.message }}`
An error occurred during the workflow execution.
[View Failed Workflow](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
embed-color: 16711680🤖 Prompt for AI Agents
In .github/workflows/dev-ci-cd.yml lines 94 to 105, the failure notification
step lacks defensive coding to prevent the workflow from failing if the Discord
notification itself fails. Add `continue-on-error: true` to this step to ensure
the workflow continues even if the notification fails. Also, include the commit
message in the embed description similar to the success notification step to aid
in troubleshooting.
.github/workflows/dev-ci-cd.yml
Outdated
| An error occurred during the workflow execution. | ||
| [View Failed Workflow](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}) | ||
| embed-color: 16711680 | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
불필요한 트레일링 스페이스 제거 필요
YAMLlint 가 지적한 것처럼 106번째 줄에 공백이 남아 있습니다. 규칙 위반으로 CI 가 실패할 여지가 있으니 빈 줄에서 공백을 삭제해주세요.
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 106-106: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
In .github/workflows/dev-ci-cd.yml at line 106, there is an unnecessary trailing
space on an otherwise empty line. Remove all trailing whitespace characters from
this line to comply with YAMLlint rules and prevent CI failures.
|
🔗 관련 이슈
📘 작업 유형
📙 작업 내역
🧪 테스트 내역
🎨 스크린샷 또는 시연 영상 (선택)
✅ PR 체크리스트
💬 추가 설명 or 리뷰 포인트 (선택)
Summary by CodeRabbit