YAPP-Github · minwoo1999 · Aug 16, 2025 · Aug 14, 2025 · Aug 14, 2025 · Aug 14, 2025
diff --git a/apis/src/main/kotlin/org/yapp/apis/book/controller/BookController.kt b/apis/src/main/kotlin/org/yapp/apis/book/controller/BookController.kt
@@ -6,8 +6,10 @@ import org.springframework.data.domain.Sort
 import org.springframework.data.web.PageableDefault
 import org.springframework.http.ResponseEntity
 import org.springframework.security.core.annotation.AuthenticationPrincipal
+import org.springframework.web.bind.annotation.DeleteMapping
 import org.springframework.web.bind.annotation.GetMapping
 import org.springframework.web.bind.annotation.ModelAttribute
+import org.springframework.web.bind.annotation.PathVariable
 import org.springframework.web.bind.annotation.PutMapping
 import org.springframework.web.bind.annotation.RequestBody
 import org.springframework.web.bind.annotation.RequestMapping
@@ -71,4 +73,13 @@ class BookController(
         return ResponseEntity.ok(response)
     }
 
+    @DeleteMapping("/my-library/{userBookId}")
+    override fun deleteBookFromMyLibrary(
+        @AuthenticationPrincipal userId: UUID,
+        @PathVariable userBookId: UUID,
+    ): ResponseEntity<Unit> {
+        bookUseCase.deleteBookFromMyLibrary(userId, userBookId)
+        return ResponseEntity.noContent().build()
+    }
+
 }
diff --git a/apis/src/main/kotlin/org/yapp/apis/book/controller/BookControllerApi.kt b/apis/src/main/kotlin/org/yapp/apis/book/controller/BookControllerApi.kt
@@ -141,4 +141,24 @@ interface BookControllerApi {
         @PageableDefault(size = 10, sort = ["createdAt"], direction = Sort.Direction.DESC)
         pageable: Pageable
     ): ResponseEntity<UserBookPageResponse>
+
+    @Operation(summary = "내 서재에 저장한 도서 삭제", description = "내 서재에 저장한 도서를 삭제합니다.")
+    @ApiResponses(
+        value = [
+            ApiResponse(
+                responseCode = "204",
+                description = "성공적으로 도서를 삭제했습니다."
+            ),
+            ApiResponse(
+                responseCode = "404",
+                description = "해당하는 도서를 찾을 수 없습니다.",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            )
+        ]
+    )
+    @DeleteMapping("/my-library/{userBookId}")
+    fun deleteBookFromMyLibrary(
+        @AuthenticationPrincipal userId: UUID,
+        @Parameter(description = "삭제할 도서 ID") @PathVariable userBookId: UUID
+    ): ResponseEntity<Unit>
-    @Operation(summary = "내 서재에 저장한 도서 삭제", description = "내 서재에 저장한 도서를 삭제합니다.")
-    @ApiResponses(
-        value = [
-            ApiResponse(
-                responseCode = "204",
-                description = "성공적으로 도서를 삭제했습니다."
-            ),
-            ApiResponse(
-                responseCode = "404",
-                description = "해당하는 도서를 찾을 수 없습니다.",
-                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
-            )
-        ]
-    )
-    @DeleteMapping("/my-library/{userBookId}")
-    fun deleteBookFromMyLibrary(
-        @AuthenticationPrincipal userId: UUID,
-        @Parameter(description = "삭제할 도서 ID") @PathVariable userBookId: UUID
-    ): ResponseEntity<Unit>
+    @Operation(summary = "내 서재에 저장한 도서 삭제", description = "내 서재에 저장한 도서를 삭제합니다.")
+    @ApiResponses(
+        value = [
+            ApiResponse(
+                responseCode = "204",
+                description = "성공적으로 도서를 삭제했습니다."
+            ),
+            ApiResponse(
+                responseCode = "401",
+                description = "인증 실패",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            ),
+            ApiResponse(
+                responseCode = "403",
+                description = "권한 없음",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            ),
+            ApiResponse(
+                responseCode = "404",
+                description = "해당하는 도서를 찾을 수 없습니다.",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            )
+        ]
+    )
+    @DeleteMapping("/my-library/{userBookId}")
+    fun deleteBookFromMyLibrary(
+        @AuthenticationPrincipal userId: UUID,
+        @Parameter(description = "삭제할 도서 ID") @PathVariable("userBookId") userBookId: UUID
+    ): ResponseEntity<Unit>
-    @Operation(summary = "내 서재에 저장한 도서 삭제", description = "내 서재에 저장한 도서를 삭제합니다.")
-    @ApiResponses(
-        value = [
-            ApiResponse(
-                responseCode = "204",
-                description = "성공적으로 도서를 삭제했습니다."
-            ),
-            ApiResponse(
-                responseCode = "404",
-                description = "해당하는 도서를 찾을 수 없습니다.",
-                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
-            )
-        ]
-    )
-    @DeleteMapping("/my-library/{userBookId}")
-    fun deleteBookFromMyLibrary(
-        @AuthenticationPrincipal userId: UUID,
-        @Parameter(description = "삭제할 도서 ID") @PathVariable userBookId: UUID
-    ): ResponseEntity<Unit>
+    @Operation(summary = "내 서재에 저장한 도서 삭제", description = "내 서재에 저장한 도서를 삭제합니다.")
+    @ApiResponses(
+        value = [
+            ApiResponse(
+                responseCode = "204",
+                description = "성공적으로 도서를 삭제했습니다."
+            ),
+            ApiResponse(
+                responseCode = "401",
+                description = "인증 실패",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            ),
+            ApiResponse(
+                responseCode = "403",
+                description = "권한 없음",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            ),
+            ApiResponse(
+                responseCode = "404",
+                description = "해당하는 도서를 찾을 수 없습니다.",
+                content = [Content(schema = Schema(implementation = ErrorResponse::class))]
+            )
+        ]
+    )
+    @DeleteMapping("/my-library/{userBookId}")
+    fun deleteBookFromMyLibrary(
+        @AuthenticationPrincipal userId: UUID,
+        @Parameter(description = "삭제할 도서 ID") @PathVariable("userBookId") userBookId: UUID
+    ): ResponseEntity<Unit>
 }
diff --git a/apis/src/main/kotlin/org/yapp/apis/book/service/UserBookService.kt b/apis/src/main/kotlin/org/yapp/apis/book/service/UserBookService.kt
@@ -83,4 +83,9 @@ class UserBookService(
             completedCount = userBookStatusCountsVO.completedCount
         )
     }
+
+    fun deleteUserBook(userBookId: UUID, userId: UUID) {
+        validateUserBookExists(userBookId, userId)
+        userBookDomainService.deleteById(userBookId)
+    }
 }
diff --git a/apis/src/main/kotlin/org/yapp/apis/book/usecase/BookUseCase.kt b/apis/src/main/kotlin/org/yapp/apis/book/usecase/BookUseCase.kt
@@ -87,6 +87,15 @@ class BookUseCase(
         return userBookService.findUserBooksByDynamicConditionWithStatusCounts(userId, status, sort, title, pageable)
     }
 
+    @Transactional
+    fun deleteBookFromMyLibrary(
+        userId: UUID,
+        userBookId: UUID
+    ) {
+        userService.validateUserExists(userId)
+        userBookService.deleteUserBook(userBookId, userId)
+    }
+
     private fun mergeWithUserBookStatus(
         searchedBooks: List<BookSummary>,
         userId: UUID

diff --git a/domain/src/main/kotlin/org/yapp/domain/readingrecord/ReadingRecordRepository.kt b/domain/src/main/kotlin/org/yapp/domain/readingrecord/ReadingRecordRepository.kt
@@ -9,6 +9,7 @@ interface ReadingRecordRepository {
 
     fun save(readingRecord: ReadingRecord): ReadingRecord
 
+    fun deleteAllByUserBookId(userBookId: UUID)
 
     fun findById(id: UUID): ReadingRecord?
 

diff --git a/domain/src/main/kotlin/org/yapp/domain/userbook/UserBookDomainService.kt b/domain/src/main/kotlin/org/yapp/domain/userbook/UserBookDomainService.kt
@@ -6,11 +6,13 @@ import org.yapp.domain.userbook.vo.HomeBookVO
 import org.yapp.domain.userbook.vo.UserBookInfoVO
 import org.yapp.domain.userbook.vo.UserBookStatusCountsVO
 import org.yapp.globalutils.annotation.DomainService
+import org.yapp.domain.readingrecord.ReadingRecordRepository
 import java.util.*
 
 @DomainService
 class UserBookDomainService(
-    private val userBookRepository: UserBookRepository
+    private val userBookRepository: UserBookRepository,
+    private val readingRecordRepository: ReadingRecordRepository
 ) {
     fun upsertUserBook(
         userId: UUID,
@@ -77,6 +79,11 @@ class UserBookDomainService(
         return userBookRepository.existsByIdAndUserId(userBookId, userId)
     }
 
+    fun deleteById(userBookId: UUID) {
+        readingRecordRepository.deleteAllByUserBookId(userBookId)
+        userBookRepository.deleteById(userBookId)
+    }
+
     fun findBooksWithRecordsOrderByLatest(userId: UUID): List<HomeBookVO> {
         val resultTriples = userBookRepository.findRecordedBooksSortedByRecency(userId)
 

diff --git a/domain/src/main/kotlin/org/yapp/domain/userbook/UserBookRepository.kt b/domain/src/main/kotlin/org/yapp/domain/userbook/UserBookRepository.kt
@@ -12,6 +12,7 @@ interface UserBookRepository {
     fun existsByIdAndUserId(id: UUID, userId: UUID): Boolean
     fun findById(id: UUID): UserBook?
     fun save(userBook: UserBook): UserBook
+    fun deleteById(id: UUID)
     fun findAllByUserId(userId: UUID): List<UserBook>
     fun findAllByUserIdAndBookIsbn13In(userId: UUID, bookIsbn13s: List<String>): List<UserBook>
     fun findUserBooksByDynamicCondition(

diff --git a/infra/src/main/kotlin/org/yapp/infra/readingrecord/repository/JpaReadingRecordRepository.kt b/infra/src/main/kotlin/org/yapp/infra/readingrecord/repository/JpaReadingRecordRepository.kt
@@ -11,6 +11,8 @@ interface JpaReadingRecordRepository : JpaRepository<ReadingRecordEntity, UUID>,
 
     fun findAllByUserBookId(userBookId: UUID): List<ReadingRecordEntity>
 
+    fun deleteAllByUserBookId(userBookId: UUID)
+
     fun findAllByUserBookId(userBookId: UUID, pageable: Pageable): Page<ReadingRecordEntity>
 
     fun findAllByUserBookIdIn(userBookIds: List<UUID>): List<ReadingRecordEntity>

diff --git a/...c/main/kotlin/org/yapp/infra/readingrecord/repository/impl/ReadingRecordRepositoryImpl.kt b/...c/main/kotlin/org/yapp/infra/readingrecord/repository/impl/ReadingRecordRepositoryImpl.kt
@@ -21,6 +21,10 @@ class ReadingRecordRepositoryImpl(
         return savedEntity.toDomain()
     }
 
+    override fun deleteAllByUserBookId(userBookId: UUID) {
+        jpaReadingRecordRepository.deleteAllByUserBookId(userBookId)
+    }
+
     override fun findById(id: UUID): ReadingRecord? {
         return jpaReadingRecordRepository.findByIdOrNull(id)?.toDomain()
     }

diff --git a/infra/src/main/kotlin/org/yapp/infra/userbook/repository/impl/UserBookRepositoryImpl.kt b/infra/src/main/kotlin/org/yapp/infra/userbook/repository/impl/UserBookRepositoryImpl.kt
@@ -38,6 +38,10 @@ class UserBookRepositoryImpl(
         return savedEntity.toDomain()
     }
 
+    override fun deleteById(id: UUID) {
+        jpaUserBookRepository.deleteById(id)
+    }
+
     override fun findAllByUserId(userId: UUID): List<UserBook> {
         return jpaUserBookRepository.findAllByUserId(userId).map { it.toDomain() }
     }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,6 +9,7 @@ interface ReadingRecordRepository {

		fun save(readingRecord: ReadingRecord): ReadingRecord

		fun deleteAllByUserBookId(userBookId: UUID)
Copy link coderabbitai bot Aug 14, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) 반환값 설계(옵션): 삭제 건수 반환 고려 Line [12]의 `deleteAllByUserBookId`는 Unit을 반환합니다. 운영/검증(로깅, 모니터링, E2E 테스트) 관점에선 삭제된 행 수(Long)를 반환하면 유용합니다. 필수는 아니나, “정말로 연관 독서 기록이 모두 제거되었는지”를 상위에서 검증할 수 있습니다. 인프라 레이어(JPA)도 동일 시그니처로 맞추면 일관성이 좋아집니다. 🤖 Prompt for AI Agents In domain/src/main/kotlin/org/yapp/domain/readingrecord/ReadingRecordRepository.kt around line 12, change the deleteAllByUserBookId signature to return the deleted-row count (Long) instead of Unit; update the repository interface method to return Long, adjust any concrete implementations (including the JPA/infrastructure repository method) to return and propagate the deletion count, and update callers/tests to expect and, where useful, assert the returned Long so callers can verify that related reading records were actually removed.

		fun findById(id: UUID): ReadingRecord?

Expand Down