Feature#137 : 마이페이지 디테일 수정 및 이전 활동내역 작업 완료#141
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
브랜치명 변경으로 PR 을 다시 올렸습니다. |
| internal class PreviousHistoryUseCase @Inject constructor( | ||
| private val userRepository: UserRepository | ||
| ){ | ||
| operator fun invoke() = userRepository.getUserActivityHistories().map { result -> | ||
| PreviousHistoryState( | ||
| items = result.activityUnits.map { unit -> | ||
| PreviousHistoryState.History( | ||
| generation = unit.generation, | ||
| position = unit.position, | ||
| activityStartDate = unit.activityStartDate, | ||
| activityEndDate = unit.activityEndDate | ||
| ) | ||
| } | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
C: viewModel 단에서 바로 userRepository를 주입받고, 그리고 UserActivityHistories -> PreviousHistoryState로 변환하는건 UserActivityHistories 확장함수로 (toState)로 처리하는건 어떨까요?
일반적인 경우에서 UseCase는 도메인 레이어에 위치하다보니 헷갈려하시는 분들이 생길 것 같습니다.
There was a problem hiding this comment.
원래 전달해주신대로 처리를 하려고 했으나 매핑 처리하는건
뷰모델에서 담당하는건 불필요하다 판단해서 유즈케이스로 분리를 했었거든요
마지막 줄 코멘트 때문이라면 그냥 뷰모델에서 처리해야겠네요
There was a problem hiding this comment.
변경처리했습니다
TaeseongYun
force-pushed
the
feature/#137-mypage-detail
branch
from
ba40e07 to
cb8e5bf
Compare
DongChyeon
left a comment
DongChyeon
left a comment
There was a problem hiding this comment.
고생하셨습니다! 코멘트 단거 몇개만 확인해주세요
There was a problem hiding this comment.
R:
Card(
modifier = modifier.fillMaxWidth(),
shape = RoundedCornerShape(8.dp),
colors = CardDefaults.cardColors(containerColor = YappTheme.colorScheme.staticWhite),
border = BorderStroke(
color = YappTheme.colorScheme.lineSolidAlternative,
width = 1.dp
)
) {
Column {
Row(
modifier = Modifier
.fillMaxWidth()
.background(YappTheme.colorScheme.backgroundElevatedAlternative)
.padding(horizontal = 16.dp, vertical = 10.dp),
horizontalArrangement = Arrangement.SpaceEvenly,
verticalAlignment = Alignment.CenterVertically
) {피그마 디자인과 같이 배경색상 변경 및 테두리 처리해주시면 감사하겠습니다.
There was a problem hiding this comment.
R:
internal class AttendHistoryUseCase @Inject constructor(
private val attendanceRepository: AttendanceRepository,
private val scheduleRepository: ScheduleRepository,
) {sessionRepository -> scheduleRepository 네이밍 변경이 반영되지 않아서 컴파일 오류가 발생하는 것 같습니다
There was a problem hiding this comment.
R:
파일 이름 오타 HistoryNavigatoion -> HistoryNavigation 수정해주시면 감사하겠습니다.
There was a problem hiding this comment.
꼼꼼한 확인 항상 감사합니다 🙇♂️
DongChyeon
left a comment
DongChyeon
left a comment
There was a problem hiding this comment.
수정하시느라 고생하셨습니다!
마지막으로 하나만 수정해주시고 병합해주시면 됩니다!
| .padding(horizontal = 20.dp) | ||
| .height(56.dp), | ||
| onClickSettings = onClickSettings | ||
| onClickSettings = { onIntent(ProfileIntent.ClickLogout) } |
There was a problem hiding this comment.
| onClickSettings = { onIntent(ProfileIntent.ClickLogout) } | |
| onClickSettings = { onIntent(ProfileIntent.ClickSettings) } |
R: ClickSettings 호출하도록 수정해주세요
There was a problem hiding this comment.
확인을 제대로 안했네요 ;; 수정처리했습니다
3 participants
💡 Issue
🌱 Key changes
✅ To Reviewers
📸 스크린샷
브랜치 명 변경으로 인해 PR 이 닫혀서 다시 열었습니다.