Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs HLTAS/hltas#11 merged
I try my best not to touch any thing else beside bxt-rs for the implementation. There are a few problems. The obvious one would be how to ignore some frames. Thus a parameter for
smoothed_viewsinstead of another member forFramestruct. The upside would be no need to store extra data and doing state stuffs between bxt-rs and BXT. It might look ugly, I guess.Also, while working on this,
unwrap_anglesis doing some fractional math with f32. It does have some problems toward what I want to do here. I want to get the inputviewsbut after some math the value is a bit off (for examples, -2pi becomes 0.005 degrees). It only affects the output views for the override line, doesn't affect TAS playback so that should be fine.