Skip to content

Tweak - Filter to suppress notice when invalid metadata #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daigo75 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tweak - Filter to suppress notice when invalid metadata #348

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d285052
Added composer.json file
daigo75 Sep 9, 2014
c42b324
Corrected licence in composer.json
daigo75 Sep 9, 2014
18c4457
Merge remote-tracking branch 'upstream/master'
Mar 17, 2020
b147fab
Added filter to allow suppressing the "invalid meta" notice
Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Puc/v4p9/Metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,29 @@ protected static function createFromJson($json, $target) {
$apiResponse = json_decode($json);
if ( empty($apiResponse) || !is_object($apiResponse) ){
$errorMessage = "Failed to parse update metadata. Try validating your .json file with http://jsonlint.com/";
do_action('puc_api_error', new WP_Error('puc-invalid-json', $errorMessage));
trigger_error($errorMessage, E_USER_NOTICE);

$api_error = new WP_Error('puc-invalid-json', $errorMessage);
do_action('puc_api_error', $api_error);

// Allow 3rd parties to suppress the notice, as they might have their own
// error handling mechanism in place
// @link https://github.com/YahnisElsts/plugin-update-checker/issues/347
if(apply_filters('puc_show_trigger_api_response_error', true, $api_error)) {
trigger_error($errorMessage, E_USER_NOTICE);
}
return false;
}

$valid = $target->validateMetadata($apiResponse);
if ( is_wp_error($valid) ){
do_action('puc_api_error', $valid);
trigger_error($valid->get_error_message(), E_USER_NOTICE);

// Allow 3rd parties to suppress the notice, as they might have their own
// error handling mechanism in place
// @link https://github.com/YahnisElsts/plugin-update-checker/issues/347
if(apply_filters('puc_show_trigger_api_response_error', true, $valid)) {
trigger_error($valid->get_error_message(), E_USER_NOTICE);
}
return false;
}

Expand Down