Skip to content
This repository was archived by the owner on Jul 15, 2019. It is now read-only.

Replace request with got#17

Open
avaly wants to merge 1 commit intoYahooArchive:masterfrom
avaly:refactor/replace-request-with-got
Open

Replace request with got#17
avaly wants to merge 1 commit intoYahooArchive:masterfrom
avaly:refactor/replace-request-with-got

Conversation

@avaly
Copy link

@avaly avaly commented Oct 15, 2017

This PR replaces request with a lighter-weight got and adds a unit test for loading of images from URLs.

Before:

$ yarn install --production
// node_modules: 6901208 bytes, 727 files

After:

$ yarn install --production
// node_modules: 2227162 bytes, 260 files

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@coveralls
Copy link

coveralls commented Oct 15, 2017

Coverage Status

Coverage decreased (-71.0%) to 8.012% when pulling 8f952ee on avaly:refactor/replace-request-with-got into 63f11c6 on yahoo:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants