This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Open
Conversation
| it { is_expected.not_to be_able_to(:view_as, :superuser) } | ||
| it { is_expected.not_to be_able_to(:appoint, :superuser) } | ||
| it { is_expected.not_to be_able_to(:destroy, User, role: 'superuser') } | ||
| it { is_expected.not_to be_able_to(:update, User, role: 'superuser') } |
Collaborator
Author
There was a problem hiding this comment.
these two fail; I haven't been able to determine why
Collaborator
Author
There was a problem hiding this comment.
I'll dig into cancancan and try to figure this out
Collaborator
Author
|
Note that this PR should also remove all of the controller tests that it obsoletes |
Contributor
|
I'll review the spec to make sure all abilities were covered, and following the resolution of these two tests failing you should deal with all the controller updates and I'll review again once those are done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1606