Skip to content

fix: improve error handling for event file opening#1739

Merged
YamatoSecurity merged 2 commits intomainfrom
remove-eprintln
Feb 23, 2026
Merged

fix: improve error handling for event file opening#1739
YamatoSecurity merged 2 commits intomainfrom
remove-eprintln

Conversation

@fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Feb 21, 2026

What Changed

  • Remove eprintln that breaks the progress bar layout.

Evidence

Integraion-Test

I’d appreciate it if you could check it when you have time🙏

@fukusuket fukusuket requested a review from Copilot February 21, 2026 08:12
@fukusuket fukusuket self-assigned this Feb 21, 2026
@fukusuket fukusuket added the bug Something isn't working label Feb 21, 2026
@fukusuket fukusuket added this to the 3.8.0 milestone Feb 21, 2026
@fukusuket fukusuket marked this pull request as ready for review February 21, 2026 08:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves runtime diagnostics when an EVTX event file cannot be opened by replacing direct stderr printing with the project’s structured error reporting (verbose alert + aggregated error log stack).

Changes:

  • Add a multi-line, contextual error message including the event file path and underlying error.
  • Respect verbose_flag for immediate stderr output and quiet_errors_flag for suppressing error-log aggregation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!!

@YamatoSecurity YamatoSecurity merged commit 23c95e4 into main Feb 23, 2026
8 checks passed
@YamatoSecurity YamatoSecurity deleted the remove-eprintln branch February 23, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants