Skip to content

fix: Correct CSV header output handling#284

Merged
YamatoSecurity merged 1 commit intomainfrom
282-fix-commna
Dec 17, 2025
Merged

fix: Correct CSV header output handling#284
YamatoSecurity merged 1 commit intomainfrom
282-fix-commna

Conversation

@fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Dec 17, 2025

Closed #282
It was caused by an extra comma being appended at the end of the CSV header.
I expect this issue to be resolved with this fix. Could you please confirm?🙏

Integration-Test

@fukusuket fukusuket self-assigned this Dec 17, 2025
@fukusuket fukusuket requested a review from Copilot December 17, 2025 23:36
@fukusuket fukusuket added the bug Something isn't working label Dec 17, 2025
@fukusuket fukusuket added this to the v2.15.0 milestone Dec 17, 2025
@fukusuket fukusuket marked this pull request as ready for review December 17, 2025 23:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a trailing comma bug in CSV header generation for two timeline commands. The old code used a loop that appended a comma after each header field, resulting in an extra comma at the end of the header line. The fix replaces this with the join(",") method which correctly doesn't add a trailing comma.

  • Refactored CSV header writing to use join(",") instead of loop-based concatenation
  • Applied the fix consistently to both timelineTasks and timelineLogon commands
  • Aligns with the pattern already used in several other files in the codebase

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/takajopkg/timelineTasks.nim Replaced loop-based header concatenation with join(",") to eliminate trailing comma in CSV header output
src/takajopkg/timelineLogon.nim Replaced loop-based header concatenation with join(",") to eliminate trailing comma in CSV header output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket That fixed it. Thanks so much!!!

@YamatoSecurity YamatoSecurity merged commit 812b5cd into main Dec 17, 2025
9 checks passed
@YamatoSecurity YamatoSecurity deleted the 282-fix-commna branch December 17, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Logon timeline seems to be corrupted

3 participants