fix: Correct CSV header output handling#284
Merged
YamatoSecurity merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a trailing comma bug in CSV header generation for two timeline commands. The old code used a loop that appended a comma after each header field, resulting in an extra comma at the end of the header line. The fix replaces this with the join(",") method which correctly doesn't add a trailing comma.
- Refactored CSV header writing to use
join(",")instead of loop-based concatenation - Applied the fix consistently to both
timelineTasksandtimelineLogoncommands - Aligns with the pattern already used in several other files in the codebase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/takajopkg/timelineTasks.nim | Replaced loop-based header concatenation with join(",") to eliminate trailing comma in CSV header output |
| src/takajopkg/timelineLogon.nim | Replaced loop-based header concatenation with join(",") to eliminate trailing comma in CSV header output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YamatoSecurity
approved these changes
Dec 17, 2025
Collaborator
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket That fixed it. Thanks so much!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #282
It was caused by an extra comma being appended at the end of the CSV header.
I expect this issue to be resolved with this fix. Could you please confirm?🙏
Integration-Test