fix: update link generation for alert titles in content.htm#285
fix: update link generation for alert titles in content.htm#285YamatoSecurity merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes link generation for alert titles in the detection rule list by constructing the correct URL with query parameters instead of using raw file paths. The change replaces the direct use of rule[1] (which contains the file path from the database) with a properly formatted URL pattern that matches the API endpoint expectations.
Key Changes
- Changed from using
rule[1](file path) to constructing a URL with"rule/content?alert_title=" + rule[0]whererule[0]is the alert title - This aligns the link construction with the expected API endpoint pattern defined in
src/takajopkg/web/controllers/rules.nim
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@fukusuket Thanks! Can you explain more about how I need to run I have a |
|
@YamatoSecurity |
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket I see, LGTM! Thanks so much!!
Closed #280
I expect this issue to be resolved with this fix. Could you please confirm?🙏
When verifying the fix, we need to run
cp -r template ./takajo/in advance.Integraion-Test