fix: add support for reading Windows versions in metrics command#287
Merged
YamatoSecurity merged 7 commits intomainfrom Dec 18, 2025
Merged
fix: add support for reading Windows versions in metrics command#287YamatoSecurity merged 7 commits intomainfrom
YamatoSecurity merged 7 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for reading Windows versions from a CSV configuration file in the automagic command. Previously, the automagic command would create a metrics-computers command without loading the Windows version mappings, resulting in missing OS information in the output.
Key changes:
- Added call to
readWindowsVersions()to load Windows version mappings fromconf/windows_versions.csv - Pass the loaded Windows versions to the
metricsComputersCmdconstructor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…test' and adjust build conditions for macOS 15 Intel
Collaborator
Author
|
Since the Release automation GitHub Actions are failing (this is unrelated to this PR)... :( , I plan to fix them in a separate PR. |
YamatoSecurity
approved these changes
Dec 18, 2025
Collaborator
YamatoSecurity
left a comment
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket LGTM!! Thanks so much!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #286
I expect this issue to be resolved with this fix. Could you please confirm?🙏
Integraion-Test