feat: add RuleID to TimelineSuspiciousProcesses.csv#292
Merged
YamatoSecurity merged 1 commit intomainfrom Dec 19, 2025
Merged
Conversation
…test' and adjust build conditions for macOS 15 Intel
There was a problem hiding this comment.
Pull request overview
This PR adds the RuleID field to the TimelineSuspiciousProcesses CSV output, enhancing the forensic timeline with rule identification information alongside the existing RuleTitle and RuleAuthor fields.
Key changes:
- Extended the HayabusaJson type to include RuleID as a required field
- Added RuleID extraction and output to both Security 4688 and Sysmon 1 process creation event handlers
- Updated CSV header to include RuleID column between RuleAuthor and Cmdline
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/takajopkg/hayabusaJson.nim | Added RuleID as a required field in the HayabusaJson type definition and validation logic |
| src/takajopkg/timelineSuspiciousProcesses.nim | Added RuleID extraction, display, and CSV export for both Security 4688 and Sysmon 1 event types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YamatoSecurity
approved these changes
Dec 19, 2025
Collaborator
YamatoSecurity
left a comment
YamatoSecurity
left a comment
There was a problem hiding this comment.
@fukusuket LGTM! Thanks so much!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #291
I added RuleId! Could you please confirm?🙏
Integration-Test