Authorization header is not required in module-attach client #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
force-pushed
the
autheorization-header-is-not-required-in-module-attach
branch
from
539e200 to
db3d9f5
Compare
Yang-33
added a commit
that referenced
this pull request
May 17, 2024
## Changes The constructor of line-bot-sdk-nodejs client modifies the given config, which should ideally behave immutably. Reusing the config as is can lead to unexpected behavior(see below sample `#2`). This change ensures that the config is not unintentionally overwritten. ## How to reproduce this (normal) ```ts // #1 (it works, but `config`'s baseURL is updated expectedly) const config = { channelAccessToken: "token-token", }; const blobClient = new messagingApi.MessagingApiBlobClient(config); // config.baseURL -> https://api-data.line.me (Unexpected, but it works) ``` (this issue) Executing the following code does not set `api.line-data.me`. A workaround is to clone the config, but this is not convenient and debugging can be troublesome. ```ts // #2 (blob doesn't work, because the first unexpected update blocks blob client uses expected baseURL) const config = { channelAccessToken: "token-token", }; const client = new messagingApi.MessagingApiClient(config); // config.baseURL -> https://api.line.me const blobClient = new messagingApi.MessagingApiBlobClient(config); // config.baseURL -> https://api.line.me, not https://api-data.line.me (Unexpected, and it won't work) ```
Yang-33
force-pushed
the
master
branch
5 times, most recently
from
41cb076 to
ae682ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bodyに入れれば十分なので、headerを消す