03 Add ESM test project #16
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
force-pushed
the
03-add-esm-test-project
branch
from
b7af762 to
3e2308d
Compare
Yang-33
force-pushed
the
02-support-only-esm-at-first
branch
2 times, most recently
from
c697249 to
8aa376d
Compare
Yang-33
force-pushed
the
03-add-esm-test-project
branch
2 times, most recently
from
3126387 to
403e115
Compare
Yang-33
force-pushed
the
02-support-only-esm-at-first
branch
from
fb798c5 to
1cba2c3
Compare
Eventually, we will support both ESM and CJS, but this change will first support ESM only. The changes are simple. 1. This changed `import hoge from "./hoge";` to `import hoge from "./hoge.js";` This is the majority of the changes. 2. This specified in the package.json that it is ESM (`"type": "module"`). 3. This modified the tsconfig.json for ESM. Subsequent changes will reintroduce support for CJS. As a result, line-bot-sdk-nodejs is expected to become a dual package.
Yang-33
force-pushed
the
03-add-esm-test-project
branch
from
403e115 to
5a813e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESMでコンパイル + 動かせるようにしただけ
tsconfig.jsonなどがひどい