Missing node warning and quickfixes#402
Merged
desplesda merged 8 commits intoYarnSpinnerTool:mainfrom Apr 10, 2025
Merged
Conversation
pappleby
commented
Mar 23, 2025
Comment on lines
+236
to
+246
| suggestions = suggestions.Prepend( | ||
| new CommandOrCodeAction( | ||
| new CodeAction | ||
| { | ||
| Title = $"Generate node '{jumpDestination}'", | ||
| Kind = CodeActionKind.QuickFix, | ||
| IsPreferred = true, | ||
| Edit = new WorkspaceEdit { Changes = insertDeclarationEdit }, | ||
| } | ||
| ) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Would be great if this could move the cursor to the newly created node. Didn't find a way to do this with an edit, but maybe it's possible with a command instead?
Contributor
Author
There was a problem hiding this comment.
Command is a no go :/ (won't show up as a suggestion if its not a CodeAction QuickFix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To update the documentation on yarnspinner.dev, please visit the documentation repository.
What is the current behavior? (You can also link to an open issue here)
Feature Request: Improved support for missing nodes IssuesDiscussion#15
What is the new behavior (if this is a feature change)?
This adds 2/3 requested improvements to the VSCode extension's handling of missing nodes:
jumpstatement to a node name that does not exist in the current projectDoes this pull request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Nope!
Other information: