Skip to content

Update Microsoft.CodeAnalysis.CSharp package#414

Merged
desplesda merged 7 commits intoYarnSpinnerTool:mainfrom
pappleby:Update-CodeAnalysis.CSharp-package
Jul 17, 2025
Merged

Update Microsoft.CodeAnalysis.CSharp package#414
desplesda merged 7 commits intoYarnSpinnerTool:mainfrom
pappleby:Update-CodeAnalysis.CSharp-package

Conversation

@pappleby
Copy link
Copy Markdown
Contributor

@pappleby pappleby commented Jul 6, 2025

  • Please check if the pull request fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated to describe this change

To update the documentation on yarnspinner.dev, please visit the documentation repository.

  • What kind of change does this pull request introduce?
  • Bug Fix
  • Feature
  • Something else
  • What is the current behavior? (You can also link to an open issue here)
    Using the required member syntax in a C# file makes the language server unable to find command / function definitions in that file. (reported on discord)

  • What is the new behavior (if this is a feature change)?
    New C# syntax (ie anything added since 8/12/2021) will no longer break C# command / function definition lookup.

  • Does this pull request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

  • Other information:

@pappleby pappleby marked this pull request as draft July 6, 2025 17:33
@pappleby
Copy link
Copy Markdown
Contributor Author

pappleby commented Jul 6, 2025

Pretty sure the pipeline failure is unrelated (also failing in main ).

@pappleby pappleby marked this pull request as ready for review July 6, 2025 17:47

// Then

Assert.NotNull(hoverResult);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sure that this test fails if there are no hover results (otherwise test will only fail if there is a hoverResult with different values).

@desplesda desplesda merged commit 2fa2452 into YarnSpinnerTool:main Jul 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants