Update Microsoft.CodeAnalysis.CSharp package#414
Merged
desplesda merged 7 commits intoYarnSpinnerTool:mainfrom Jul 17, 2025
Merged
Update Microsoft.CodeAnalysis.CSharp package#414desplesda merged 7 commits intoYarnSpinnerTool:mainfrom
desplesda merged 7 commits intoYarnSpinnerTool:mainfrom
Conversation
Contributor
Author
|
Pretty sure the pipeline failure is unrelated (also failing in main ). |
pappleby
commented
Jul 6, 2025
|
|
||
| // Then | ||
|
|
||
| Assert.NotNull(hoverResult); |
Contributor
Author
There was a problem hiding this comment.
Makes sure that this test fails if there are no hover results (otherwise test will only fail if there is a hoverResult with different values).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To update the documentation on yarnspinner.dev, please visit the documentation repository.
What is the current behavior? (You can also link to an open issue here)
Using the required member syntax in a C# file makes the language server unable to find command / function definitions in that file. (reported on discord)
What is the new behavior (if this is a feature change)?
New C# syntax (ie anything added since 8/12/2021) will no longer break C# command / function definition lookup.
Does this pull request introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information: