Paris improvements forvscode and playground (WIP)#423
Conversation
The old C# language server has been replaced by the new TypeScript language server in YarnSpinner-LanguageServer repo.
…ris-improvements-forvscode-and-playground
…nflict in TypeCheckerListener per Jon's PR comment
…hen jon suggested consistenfying diags
…/github.com/YarnSpinnerTool/YarnSpinner into paris-improvements-forvscode-and-playground
…-playground' Resolved conflict in DiagnosticDescriptor.cs by renumbering our error codes: - YS0017/YS0018 from remote (line/shadow tags) preserved - Our YS0017/YS0018 renumbered to YS0021/YS0022 (stray/unenclosed commands) - Updated workspace.ts to reference new error codes
| /// <summary> | ||
| /// all function names called within this node | ||
| /// </summary> | ||
| public List<string> FunctionCalls { get; set; } = new List<string>(); |
There was a problem hiding this comment.
I wonder whether it would be useful to store names alongside locations (i.e. paths and ranges), rather than simply the function identifier, and likewise for variables, nodes, etc. (Not a requirement, just a thought.)
|
SyntaxValidationListener appears to be causing a significant slowdown when running unit tests. CI was running for 28 minutes before I cancelled the job, and when I debugged it locally it was stuck in the middle of It seems that |
…/github.com/YarnSpinnerTool/YarnSpinner into paris-improvements-forvscode-and-playground
…lidationListener is in
…/github.com/YarnSpinnerTool/YarnSpinner into paris-improvements-forvscode-and-playground
2 participants
Lots of changes in support of new LSP/VSCode Extension.