fix(planning): remove unnecessary global flag from module-level regex#1712
Merged
Yeachan-Heo merged 1 commit intoYeachan-Heo:devfrom Mar 17, 2026
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TEAM_LAUNCH_REandRALPH_LAUNCH_REinsrc/planning/artifacts.tsare declared at module level with the/g(global) flag, but each regex is only used with a singleexec()call per function invocation.The
/gflag causesRegExpobjects to maintain internallastIndexstate between calls. The current code works around this with manuallastIndex = 0resets before eachexec(), but this pattern is fragile — if the regex is ever reused elsewhere without the reset, it will silently fail to match.Fix
/gflag from bothTEAM_LAUNCH_REandRALPH_LAUNCH_RElastIndex = 0reset linesVerification
src/planning/__tests__/artifacts.test.tspassexec()without/greturns the same first match