fix: allow orchestrator to idle when sub-agents are active#1729
Closed
flobo3 wants to merge 1 commit intoYeachan-Heo:mainfrom
Closed
fix: allow orchestrator to idle when sub-agents are active#1729flobo3 wants to merge 1 commit intoYeachan-Heo:mainfrom
flobo3 wants to merge 1 commit intoYeachan-Heo:mainfrom
Conversation
Owner
|
Thanks for the contribution! Two things:
— |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: allow orchestrator to idle when sub-agents are active
Fixes #1721
When running in modes like
ralplanorralph, the orchestrator delegates work to sub-agents via theAgenttool. While the sub-agent is actively working, the orchestrator naturally has nothing to do and tries to stop/idle. However, the Stop hook (persistent-mode/skill-state) was blocking this, forcing the orchestrator into a meaningless polling loop.This PR adds a check in
checkPersistentModesto consult thesubagent-tracker. If there are active sub-agents running (getActiveAgentCount > 0), the orchestrator is correctly waiting for them to finish, and the stop event is allowed to proceed (idle state).