tweak: Add YouTube web_safari client by default#4
Open
Baplar wants to merge 1 commit intoYellow-Dog-Man:masterfrom
Open
tweak: Add YouTube web_safari client by default#4Baplar wants to merge 1 commit intoYellow-Dog-Man:masterfrom
Baplar wants to merge 1 commit intoYellow-Dog-Man:masterfrom
Conversation
The web_safari client gives access to pre-merged audio+video formats with high resolutions. It is already used by default in most cases, [except for users with cookies linked to a YouTube Premium account](yt-dlp/yt-dlp#14575), which paradoxically causes users with Premium to be stuck with 360p videos in Resonite. This change adds this option by default on all requests, which will have no impact for most users, but will allow users with YouTube Premium accounts to access high resolution videos like all other users, at the tiny overhead cost of a few additional requests to fetch the available formats for this additional client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web_safari client gives access to pre-merged audio+video formats with high resolutions. It is already used by default in most cases, except for users with cookies linked to a YouTube Premium account, which paradoxically causes users with Premium to be stuck with 360p videos in Resonite.
This change adds this option by default on all requests, which will have no impact for most users, but will allow users with YouTube Premium accounts to access high resolution videos like all other users, at the tiny overhead cost of a few additional requests to fetch the available formats for this additional client.
I compiled and tested this locally with my install of Resonite, and I can confirm that this works, both with and without the cookies option being enabled.
This should not cause any breakage in the future even if one day yt-dlp removes the web_safari client, because yt-dlp simply ignores unknown client arguments and carries on with the defaults: