Refactor QueryNodeMapper to only use DocLookup#923
Merged
aprudhomme merged 1 commit intoYelp:mainfrom Jan 28, 2026
Merged
Conversation
sarthakn7
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
QueryNodeMapperconverts the gRPC query definition into Lucene queries. This review refactors this process to useDocLookupinstead ofIndexState. This is useful since it allows for use by plugins, which don't have access to theIndexState.A couple enhancements were added to
DocLookup. AgetFieldDefOrThrowmethod, which replicates the functionality of theIndexStatemethod. AgetAllFieldNamesmethod which provides all valid field names, which was needed for construction of one of the query types.