-
Notifications
You must be signed in to change notification settings - Fork 247
Add a 'restart --replica' option #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfongatyelp
wants to merge
15
commits into
master
Choose a base branch
from
jfong/restart_replica
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,615
−14
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d0878f3
Add a restart replica option
jfongatyelp ca068d2
Handle api errors like remote_run
jfongatyelp f467d98
Add tests (thx claude)
jfongatyelp 44a3c1e
Apply suggestion from @nemacysts
jfongatyelp 06d02de
Whoops, missed a codegenerated file?
jfongatyelp cad99f1
Update paasta_tools/cli/cmds/start_stop_restart.py
jfongatyelp 1042f3d
Update paasta_tools/cli/cmds/start_stop_restart.py
jfongatyelp b2407b3
Apply suggestion from @nemacysts
jfongatyelp eebd01e
Add force param, default to configured termination_grace_period_seconds
jfongatyelp 8c53a3e
Apply suggestion from @nemacysts
jfongatyelp 79478c4
Apply suggestion from @jfongatyelp
jfongatyelp 16fab34
precommit
jfongatyelp 5cfbd67
Fix defaults and formatting on delete_pod_by_name
jfongatyelp fa98d1e
Just use pod's configured grace period instead of pulling from job_co…
jfongatyelp 77160ba
Fix tests
jfongatyelp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: i wonder if a typeddict or using the generated model would maybe be nicer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, at the very least having a named model for the response would be great... i don't really see us importing the models into
api/views/files orinstance/kubernetes.pyat all, and instead only used on the client side, so I suppose I could do both--typeddict on the api side, reference the generated model on the client side?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, i'm not sure if there's a reason for why we haven't tried using the generated named models or if we just never bothered since a lot of these endpoints predated our typing enthusiasm :p