This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Open
Conversation
If cluster_type is not specified on the command line, and only 1 cluster_type is configured, then the command will use that cluster_type. The purpose is to simplify the command-line invocation when you always have only 1 cluster type.
Baisang
suggested changes
Jan 3, 2020
Contributor
Baisang
left a comment
Baisang
left a comment
There was a problem hiding this comment.
Thanks for making this!
The only issue I see is that if there is >1 cluster_type, but the user does not specify one, we need to surface that issue to the user in a clean way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a just a proof-of-concept. I welcome feedback on whether this is an idea you would accept, and if so, how to prepare the PR to your standards.
If cluster_type is not specified on the command line, and only 1
cluster_type is configured, then the command will use that cluster_type.
The purpose is to simplify the command-line invocation when you always
have only 1 cluster type.
Thanks!