feat: expose auto responder tokens as environment variables (#2314)

[Yeraze]

Summary

Closes #2314 — Expose auto responder tokens as environment variables for scripts.

Previously, tokens like {LONG_NAME}, {SNR}, {HOPS} were only available via command-line argument expansion, which breaks when values contain spaces. Now all tokens are available as environment variables with clean, documented names.

New environment variables added:

Variable	Source
NODE_ID	Sender's hex node ID
SHORT_NAME / LONG_NAME	Sender's node names (aliases for existing FROM_SHORT_NAME/FROM_LONG_NAME)
HOPS	Calculated hop count
SNR / RSSI	Signal quality from packet
CHANNEL	Channel number
VERSION	Sender's firmware version
NODECOUNT	Active node count
VIA_MQTT	MQTT bridge flag
IS_DIRECT	Direct message flag

Documentation updated:

• docs/developers/auto-responder-scripting.md — Full env var table expanded
• docs/features/automation.md — Summary list updated with link to full reference

Test plan

• Create an auto responder script that reads NODE_ID, SNR, HOPS, NODECOUNT from env vars
• Verify values match what the token expansion produces in text responses
• Verify LONG_NAME with spaces is accessible without parsing issues
• Full test suite passes (2987 tests)

🤖 Generated with Claude Code

[github-actions]

Good implementation for exposing environment variables! A few observations:

1. Clean aliasing: I like that you've provided NODE_ID, SHORT_NAME, LONG_NAME as aliases for the existing FROM_* variables. This gives users cleaner, more intuitive variable names while maintaining backward compatibility.

2. Conditional assignment: Good defensive programming with the conditional checks for rxSnr and rxRssi to avoid setting undefined values.

3. Type safety: Proper string conversion using String() for all numeric values.

Minor suggestion: Consider adding a debug log statement here to help with troubleshooting:

logger.debug(`🔧 Auto-responder env vars: NODE_ID=${context.nodeId}, HOPS=${context.hopsTraveled}, SNR=${message.rxSnr}, RSSI=${message.rxRssi}`);

[github-actions]

Excellent documentation update! The environment variables table is comprehensive and well-organized. I particularly appreciate:

1. Complete coverage: All the new environment variables are documented with clear examples
2. Alias explanation: Good clarification that SHORT_NAME/LONG_NAME are aliases for existing variables
3. Consistent formatting: The table format matches the existing documentation style

One minor suggestion: Consider adding a note about when these variables are available. For example:

• SNR/RSSI: Only available for direct radio reception (not MQTT bridge)
• HOPS: Always available, 0 for direct messages
• NODE_ID: Always available in hex format

This would help script authors understand data availability patterns.

[github-actions]

Code Review Summary

This PR successfully implements auto responder tokens as environment variables (closes #2314), providing a clean solution to the space-handling issues with command-line argument expansion.

✅ Strengths

Implementation Quality

• Clean aliasing: Provides intuitive NODE_ID, SHORT_NAME, LONG_NAME variables while maintaining backward compatibility with existing FROM_* variables
• Defensive programming: Proper conditional checks for optional values like rxSnr and rxRssi
• Type safety: Consistent use of String() conversion for all numeric environment variables
• Well-integrated: Seamlessly fits into the existing createScriptEnvVariables function architecture

Documentation Excellence

• Comprehensive coverage: All new environment variables are documented with clear examples
• Consistent formatting: Documentation follows established patterns and style
• Cross-referenced: Automation.md appropriately links to the detailed scripting guide
• User-focused: Addresses the core pain point mentioned in the issue (spaces in values)

Feature Completeness

• All required tokens: Covers NODE_ID, SHORT_NAME, LONG_NAME, HOPS, SNR, RSSI, CHANNEL, VERSION, NODECOUNT, VIA_MQTT, IS_DIRECT
• Backward compatible: Existing scripts continue to work unchanged
• Consistent naming: Environment variable names match the {TOKEN} syntax from documentation

📋 Technical Details

Files Modified

• ✅ src/server/meshtasticManager.ts - Core implementation (lines 8078-8113)
• ✅ docs/developers/auto-responder-scripting.md - Expanded env var table
• ✅ docs/features/automation.md - Updated summary with link to full reference

Environment Variables Added

NODE_ID, SHORT_NAME/LONG_NAME, HOPS, SNR/RSSI, CHANNEL, VERSION, NODECOUNT, VIA_MQTT, IS_DIRECT

🏆 Overall Assessment

Excellent implementation! This PR:

• ✅ Solves the core issue with argument parsing and spaces
• ✅ Maintains backward compatibility
• ✅ Provides clean, intuitive variable names
• ✅ Includes comprehensive documentation updates
• ✅ Follows established coding patterns and conventions
• ✅ Ready for production deployment

The solution is well-thought-out, properly implemented, and thoroughly documented. Users will benefit from easier script development without the complexity of argument parsing edge cases.

🚀 Ready to Merge

This PR successfully addresses issue #2314 and is ready for merging. The implementation is solid, the documentation is excellent, and the backward compatibility ensures no breaking changes for existing users.