Skip to content

fix: reclaim full space when sidebar collapsed on Messages and Map #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yeraze merged 1 commit into from
Mar 22, 2026
Merged

fix: reclaim full space when sidebar collapsed on Messages and Map #2368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions src/styles/nodes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@
}

.nodes-anchored-sidebar.collapsed {
width: 48px !important;
min-width: 48px;
max-width: 48px;
width: 0 !important;
Copy link

@github-actions github-actions bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Excellent change! Reducing collapsed width from 48px to 0 properly reclaims the full space. The overflow: visible is crucial to ensure the floating expand button remains accessible.

min-width: 0;
max-width: 0;
overflow: visible;
}

/* Resize handle on right edge of sidebar */
Expand Down Expand Up @@ -122,6 +123,14 @@
border-bottom: none;
box-shadow: none;
backdrop-filter: none;
transition: width 0.3s ease;
}

.messages-sidebar.collapsed {
Copy link

@github-actions github-actions bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great addition! The Messages sidebar was missing collapse CSS entirely - this fixes a significant UX gap. Adding the smooth transition maintains consistency with the Map sidebar behavior.

width: 0 !important;
min-width: 0;
max-width: 0;
overflow: visible;
}

.messages-split-view {
Expand Down Expand Up @@ -554,16 +563,20 @@
}

.nodes-sidebar.collapsed .sidebar-header {
Copy link

@github-actions github-actions bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Smart positioning solution! Moving the collapsed header to absolute positioning with proper z-index (1000) creates a clean floating expand button. The box-shadow on line 579 adds nice visual depth.

display: flex;
align-items: center;
justify-content: center;
padding: 0.5rem;
position: absolute;
top: 8px;
left: 8px;
padding: 0;
border-bottom: none;
background: transparent;
z-index: 1000;
width: auto;
min-height: auto;
}

.nodes-sidebar.collapsed .collapse-nodes-btn {
position: static;
margin: auto;
box-shadow: 0 2px 6px rgba(0, 0, 0, 0.3);
}

.nodes-sidebar.collapsed .sidebar-header h3 {
Expand Down Expand Up @@ -1250,14 +1263,15 @@
height: 100%;
}

/* When collapsed on mobile, show as small strip */
/* When collapsed on mobile, reclaim all space */
.nodes-anchored-sidebar.collapsed {
position: static;
Copy link

@github-actions github-actions bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Consistent mobile implementation! Good that you applied the same 0-width approach to mobile collapsed state. This ensures consistent behavior across all device sizes.

width: 40px;
min-width: 40px;
max-width: 40px;
width: 0 !important;
min-width: 0;
max-width: 0;
max-height: 100%;
padding: 0;
overflow: visible;
}

.nodes-sidebar.collapsed .sidebar-header {
Expand Down
Loading