Skip to content

fix: prevent duplicate traceroute pending records (#2364) #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yeraze merged 1 commit into from
Mar 22, 2026
Merged

fix: prevent duplicate traceroute pending records (#2364) #2380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/server/meshtasticManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3817,12 +3817,16 @@ class MeshtasticManager {
}
}
// Preserve the 'from' and 'to' node order for virtual node traceroute requests.
// This ensures subsequent responses correctly correlate with this request
// This ensures subsequent responses correctly correlate with this request
// to update route and signal characteristics in the database.
// Skip if from our own node — sendTraceroute() already recorded the request.
else if (normalizedPortNum === PortNum.TRACEROUTE_APP) {
const fromNum = meshPacket.from ? Number(meshPacket.from) : 0;
const toNum = meshPacket.to ? Number(meshPacket.to) : 0;
await databaseService.recordTracerouteRequestAsync(fromNum, toNum);
const localNodeNum = this.localNodeInfo?.nodeNum;
if (fromNum !== localNodeNum) {
await databaseService.recordTracerouteRequestAsync(fromNum, toNum);
}
}
}
}
Expand Down
Loading