-
Notifications
You must be signed in to change notification settings - Fork 318
Add Rainbow Paint and Vehicle Jump #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhanced
Are you sure you want to change the base?
Conversation
|
hopefully to add vehicle jump in..fun feature to have from the legacy |
| globals->AddItem(std::make_shared<ConditionalItem>("rainbowpaint"_J, std::make_shared<ListCommandItem>("rainbowtype"_J, "Paint Type"))); | ||
| globals->AddItem(std::make_shared<ConditionalItem>("rainbowpaint"_J, std::make_shared<BoolCommandItem>("rainbowpri"_J, "Primary"))); | ||
| globals->AddItem(std::make_shared<ConditionalItem>("rainbowpaint"_J, std::make_shared<BoolCommandItem>("rainbowsec"_J, "Secondary"))); | ||
| // globals->AddItem(std::make_shared<ConditionalItem>("rainbowpaint"_J, std::make_shared<IntCommandItem>("rainbowspeed"_J, "Speed"))); Don't know how to change the speed once it's been changed in the UI, so no speed, for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The speed control should work, I can't see anything wrong with the code right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work, but I can't figure out how to change the number inside the UI. I click it and it goes from 10 to 1 and it gets stuck there for me. I have tried clicking it like a textbox, tried sliding it both ways, but it didn't budge in the UI.
|
It would be good if you add these features in a separate tab ("Misc") inside Vehicle. |
|
So, when creating a slider, This is not the way to do it: This is the proper format: Now the slider actually works. Don't just copy and paste, actually adjust it to other feature's code. |
Note: Both of them have some formatting from the legacy YimMenu code, however the rainbow paint feature is missing the tire smoke and neon features.
Vehicle jump is almost word-for-word from the legacy YimMenu code.