Skip to content

Conversation

@pls78
Copy link
Member

@pls78 pls78 commented Apr 22, 2025

Context

  • We want to drop PHP 7.2 and 7.3 compatibility.

Summary

This PR can be summarized in the following changelog entry:

  • Drops compatibility with PHP 7.2 and 7.3.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Follow the exact same test instructions in this PR.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #401

@enricobattocchi enricobattocchi added this to the 4.6 milestone Apr 29, 2025
@enricobattocchi enricobattocchi merged commit 60793e2 into trunk Apr 29, 2025
48 of 50 checks passed
@enricobattocchi enricobattocchi deleted the feature/drop-php-7.2-7.3 branch April 29, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop compatibility with PHP 7.2 and 7.3

2 participants