Skip to content

Verify peer (see issue#4) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Verify peer (see issue#4) #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
826513b
verify-peer implemented for self signed certificates on keycloak
Dec 21, 2024
860992d
remove comments
wisgrill Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Keycloak.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ public function getEndpoint(string $endpoint)
{
if (!isset($this->discovery)) {
$plugin = plugin_load('helper', 'oauthkeycloak');
$json = file_get_contents($plugin->getConf('openidurl'));

$context = stream_context_create([
'ssl' => [
'verify_peer' => $plugin->getConf('verify-peer')
]
]);
$json = file_get_contents($plugin->getConf('openidurl'), false, $context);

if (!$json) throw new \Exception('Failed accessing ' . $plugin->getConf('openidurl'));
$this->discovery = json_decode($json, true);
}
Expand Down
1 change: 1 addition & 0 deletions conf/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
$conf['secret'] = '';

$conf['openidurl'] = '';
$conf['verify-peer'] = 1;

$conf['label'] = 'Keycloak';
$conf['color'] = '#333333';
1 change: 1 addition & 0 deletions conf/metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
$meta['secret'] = array('password');

$meta['openidurl'] = array('string');
$meta['verify-peer'] = array('onoff','_caution' => 'security');

$meta['label'] = array('string');
$meta['color'] = array('string');
1 change: 1 addition & 0 deletions lang/en/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
$lang['key'] = 'Client ID';
$lang['secret'] = 'Cient Secret';
$lang['openidurl'] = 'OpenID Connect Auto Discovery URL';
$lang['verify-peer'] = 'Verification of SSL certificate is required.';

$lang['label'] = 'Label to display on the login button';
$lang['color'] = 'Color to use with the login button';