satgen: Fix $macc_v2 x-prop #5025
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
approved these changes
Apr 16, 2025
Member
KrystalDelusion
left a comment
KrystalDelusion
left a comment
There was a problem hiding this comment.
Seems to work fine. There are some problematic seeds (e.g. -n 1 -s 1744844438), but I suspect this is not unique to the _v2 or the changes here but rather trying to sat solve multiplication of non trivial widths.
KrystalDelusion
added
the
merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Explain how this is achieved.
Fix the x-prop behavior of
$macc_v2in satgen. The satgen extension from #4818 missed to account for$macc_v2having an extraCport.If applicable, please suggest to reviewers how they can test the change.
Testing coupled to #5024