test(keys): replace useage of old methods

Author: DennisDyallo

Yubico.YubiKey/tests/integration/Yubico/YubiKey/Piv/KeyAgreeTests.cs

@@ -47,7 +47,7 @@ public void KeyAgree_SharedSecret_IsValid(
             if (keyType is KeyType.X25519)
             {
                 var testSelectedPublicKeyPeer = TestKeys.GetTestPublicKey(keyType, 2);
-                peerPublicKey = Curve25519PublicKey.CreateFromPkcs8(testSelectedPublicKeyPeer.EncodedKey);
+                peerPublicKey = Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(testSelectedPublicKeyPeer.EncodedKey);
             }
             else
             {

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/Curve25519PublicKeyTests.cs

@@ -46,7 +46,7 @@ public void CreateCurve25519FromPkcs8EncodedKey_WithValidKey_CreatesInstance(Key
         var testPublicKey = TestKeys.GetTestPublicKey(keyType);
 
         // Act
-        var publicKey = Curve25519PublicKey.CreateFromPkcs8(testPublicKey.EncodedKey);
+        var publicKey = Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(testPublicKey.EncodedKey);
         Assert.NotNull(publicKey);
 
         // Assert
@@ -63,7 +63,7 @@ public void CreateFromPkcs8_CreatesInstance(KeyType keyType)
         var testPublicPoint = testKey.GetPublicPoint();
 
         // Act
-        var publicKey = Curve25519PublicKey.CreateFromPkcs8(testKey.EncodedKey); 
+        var publicKey = Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(testKey.EncodedKey); 
 
         // Assert
         Assert.NotNull(publicKey);

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/ECPublicKeyTests.cs

@@ -43,7 +43,7 @@ public void CreateECDsaFromPkcs8EncodedKey_WithValidKey_CreatesInstance(KeyType
 
             // Act
             var publicKey = ecdsa.ExportSubjectPublicKeyInfo();
-            var publicKeyParams = ECPublicKey.CreateFromPkcs8(publicKey);
+            var publicKeyParams = ECPublicKey.CreateFromSubjectPublicKeyInfo(publicKey);
             var ecPublicKeyParams = publicKeyParams as ECPublicKey;
             Assert.NotNull(ecPublicKeyParams);
 

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/RSAPublicKeyTests.cs

@@ -35,7 +35,7 @@ public void CreateFromPkcs8_WithValidParameters_CreatesInstance()
             var publicKeyPkcs = rsa.ExportSubjectPublicKeyInfo();
 
             // Act
-            var publicKey = RSAPublicKey.CreateFromPkcs8(publicKeyPkcs);
+            var publicKey = RSAPublicKey.CreateFromSubjectPublicKeyInfo(publicKeyPkcs);
 
             // Assert
             Assert.Null(publicKey.Parameters.D);

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestKey.cs

@@ -80,8 +80,8 @@ public byte[] GetPublicPoint()
         }
 
         return KeyDefinition is { IsEllipticCurve: true, AlgorithmOid: Oids.ECDSA }
-            ? ECPublicKey.CreateFromPkcs8(EncodedKey).PublicPoint.ToArray()
-            : Curve25519PublicKey.CreateFromPkcs8(EncodedKey).PublicPoint.ToArray();
+            ? ECPublicKey.CreateFromSubjectPublicKeyInfo(EncodedKey).PublicPoint.ToArray()
+            : Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(EncodedKey).PublicPoint.ToArray();
     }
 
     public IPublicKey AsPublicKey()
@@ -93,15 +93,15 @@ public IPublicKey AsPublicKey()
 
         if (KeyDefinition.IsRSA)
         {
-            return RSAPublicKey.CreateFromPkcs8(EncodedKey);
+            return RSAPublicKey.CreateFromSubjectPublicKeyInfo(EncodedKey);
         }
 
         if (KeyDefinition is { IsEllipticCurve: true, AlgorithmOid: Oids.ECDSA })
         {
-            return ECPublicKey.CreateFromPkcs8(EncodedKey);
+            return ECPublicKey.CreateFromSubjectPublicKeyInfo(EncodedKey);
         }
 
-        return Curve25519PublicKey.CreateFromPkcs8(EncodedKey);
+        return Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(EncodedKey);
     }
 
     public byte[] GetPrivateKeyValue()

Yubico.YubiKey/tests/utilities/Yubico/YubiKey/TestUtilities/TestKeyExtensions.cs

@@ -50,19 +50,19 @@ public static PivPublicKey AsPivPublicKey(
             var keyDefinition = key.KeyDefinition;
             if (keyDefinition.IsRSA)
             {
-                var rsaPublicKey = RSAPublicKey.CreateFromPkcs8(key.EncodedKey);
+                var rsaPublicKey = RSAPublicKey.CreateFromSubjectPublicKeyInfo(key.EncodedKey);
                 var rsaPivEncodedKey = rsaPublicKey.EncodeAsPiv();
                 return PivPublicKey.Create(rsaPivEncodedKey, key.KeyType.GetPivAlgorithm());
             }
 
             if (keyDefinition is { IsEllipticCurve: true, AlgorithmOid: Oids.ECDSA })
             {
-                var ecPublicKey = ECPublicKey.CreateFromPkcs8(key.EncodedKey);
+                var ecPublicKey = ECPublicKey.CreateFromSubjectPublicKeyInfo(key.EncodedKey);
                 var ecPivEncodedKey = ecPublicKey.EncodeAsPiv();
                 return PivPublicKey.Create(ecPivEncodedKey, key.KeyType.GetPivAlgorithm());
             }
 
-            var cvPublicKey = Curve25519PublicKey.CreateFromPkcs8(key.EncodedKey);
+            var cvPublicKey = Curve25519PublicKey.CreateFromSubjectPublicKeyInfo(key.EncodedKey);
             var cvPivEncodedKey = cvPublicKey.EncodeAsPiv();
             return PivPublicKey.Create(cvPivEncodedKey, keyDefinition.KeyType.GetPivAlgorithm());
         }