chore(keys): cleanup

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/AsnPrivateKeyDecoder.cs

@@ -15,7 +15,6 @@
 using System;
 using System.Formats.Asn1;
 using System.Globalization;
-using System.Linq;
 using System.Security.Cryptography;
 
 namespace Yubico.YubiKey.Cryptography;

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/Curve25519PrivateKey.cs

@@ -45,7 +45,7 @@ public sealed class Curve25519PrivateKey : PrivateKey
     /// </summary>
     /// <returns>A <see cref="ReadOnlyMemory{T}"/> containing the private scalar value.</returns>
     public ReadOnlyMemory<byte> PrivateKey => _privateKey;
-    
+
     private Curve25519PrivateKey(
         ReadOnlyMemory<byte> privateKey,
         KeyType keyType)
@@ -61,9 +61,9 @@ private Curve25519PrivateKey(
 
         privateKey.CopyTo(_privateKey);
     }
-    
+
     /// <inheritdoc />
-    public override byte[] ExportPkcs8PrivateKey() 
+    public override byte[] ExportPkcs8PrivateKey()
     {
         ThrowIfDisposed();
         return AsnPrivateKeyEncoder.EncodeToPkcs8(_privateKey, KeyType);
@@ -96,7 +96,7 @@ public static Curve25519PrivateKey CreateFromPkcs8(ReadOnlyMemory<byte> pkcs8Enc
         using var privateKeyHandle = new ZeroingMemoryHandle(privateKey);
         return new Curve25519PrivateKey(privateKeyHandle.Data, keyType);
     }
-    
+
     /// <summary>
     /// Creates an instance of <see cref="Curve25519PrivateKey"/> from the given
     /// <paramref name="privateKey"/> and <paramref name="keyType"/>.

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/Curve25519PublicKey.cs

@@ -13,7 +13,6 @@
 // limitations under the License.
 
 using System;
-using System.Formats.Asn1;
 using System.Globalization;
 using System.Security.Cryptography;
 
@@ -60,7 +59,7 @@ private Curve25519PublicKey(
 
         publicPoint.CopyTo(_publicPoint);
     }
-    
+
     /// <summary>
     /// Converts this public key to an ASN.1 DER encoded format (X.509 SubjectPublicKeyInfo).
     /// </summary>
@@ -73,7 +72,7 @@ public override byte[] ExportSubjectPublicKeyInfo() =>
     /// <summary>
     /// Creates a new instance of <see cref="Curve25519PublicKey"/> from a DER-encoded public key.
     /// </summary>
-    /// <param name="encodedKey">
+    /// <param name="subjectPublicKeyInfo">
     /// The DER-encoded public key.
     /// </param>
     /// <returns>

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/ECPrivateKey.cs

@@ -34,7 +34,7 @@ public class ECPrivateKey : PrivateKey
         /// An <see cref="ECParameters"/> structure containing the curve parameters, key, and other
         /// cryptographic elements needed for EC operations.
         /// </value>
-        public ECParameters Parameters { get;}
+        public ECParameters Parameters { get; }
 
         /// <summary>
         /// Gets the key definition associated with this RSA private key.
@@ -85,7 +85,7 @@ protected ECPrivateKey(ECDsa ecdsaObject)
             Parameters = ecdsaObject.ExportParameters(true);
             KeyDefinition = KeyDefinitions.GetByOid(Parameters.Curve.Oid);
         }
-        
+
         /// <inheritdoc/>
         public override byte[] ExportPkcs8PrivateKey()
         {
@@ -116,18 +116,16 @@ public override void Clear()
         public static ECPrivateKey CreateFromPkcs8(ReadOnlyMemory<byte> encodedKey)
         {
             var parameters = AsnPrivateKeyDecoder.CreateECParameters(encodedKey);
+
             return CreateFromParameters(parameters);
         }
-        
-        #pragma warning disable CS0618 // Type or member is obsolete.
 
         /// <summary>
         /// Creates an instance of <see cref="ECPrivateKey"/> from the given <paramref name="parameters"/>.
         /// </summary>
         /// <param name="parameters">The parameters to create the key from.</param>
         /// <returns>An instance of <see cref="ECPrivateKey"/>.</returns>
         public static ECPrivateKey CreateFromParameters(ECParameters parameters) => new(parameters);
-        #pragma warning restore CS0618 // Type or member is obsolete
 
         /// <summary>
         /// Creates a new instance of <see cref="ECPrivateKey"/> from the given

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/ECPublicKey.cs

@@ -99,7 +99,7 @@ protected ECPublicKey(ECDsa ecdsa)
 
     /// <inheritdoc />
     public override byte[] ExportSubjectPublicKeyInfo() => AsnPublicKeyEncoder.EncodeToSubjectPublicKeyInfo(Parameters);
-    
+
     /// <summary>
     /// Creates an instance of <see cref="ECPublicKey"/> from the given <paramref name="parameters"/>.
     /// </summary>

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/RSAPrivateKey.cs

@@ -47,14 +47,14 @@ public sealed class RSAPrivateKey : PrivateKey
     /// A <see cref="KeyDefinition"/> object that describes the key's properties, including its type and length.
     /// </value>
     public KeyDefinition KeyDefinition { get; }
-    
+
     /// <inheritdoc />
     public override KeyType KeyType => KeyDefinition.KeyType;
 
     private RSAPrivateKey(RSAParameters parameters)
     {
         int keyLengthBits = parameters.DP?.Length * 8 * 2 ?? 0;
-        
+
         Parameters = parameters.NormalizeParameters();
         KeyDefinition = KeyDefinitions.GetByRSALength(keyLengthBits);
     }

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/RSAPublicKey.cs

@@ -37,14 +37,14 @@ public sealed class RSAPublicKey : PublicKey
     /// The parameters are used in cryptographic operations such as decryption and digital signature creation.
     /// </remarks>
     public RSAParameters Parameters { get; }
-    
+
     /// <summary>
     /// Gets the key definition associated with this RSA private key.
     /// </summary>
     /// <value>
     /// A <see cref="KeyDefinition"/> object that describes the key's properties, including its type and length.
     /// </value>
-    public KeyDefinition KeyDefinition  { get; }
+    public KeyDefinition KeyDefinition { get; }
 
     /// <inheritdoc />
     public override KeyType KeyType => KeyDefinition.KeyType;
@@ -82,8 +82,8 @@ public override byte[] ExportSubjectPublicKeyInfo()
     /// </exception>
     public static RSAPublicKey CreateFromParameters(RSAParameters parameters)
     {
-        if (parameters.D != null || 
-            parameters.P != null || 
+        if (parameters.D != null ||
+            parameters.P != null ||
             parameters.Q != null ||
             parameters.DP != null ||
             parameters.DQ != null ||
@@ -92,7 +92,7 @@ public static RSAPublicKey CreateFromParameters(RSAParameters parameters)
         {
             throw new ArgumentException("Parameters must not contain private key data");
         }
-        
+
         return new RSAPublicKey(parameters);
     }