refactor: rename GetByCoseCurveType method to GetByCoseCurve for consistency

Author: DennisDyallo

Yubico.YubiKey/src/Yubico/YubiKey/Cryptography/KeyDefinitions.cs

@@ -91,7 +91,7 @@ public static KeyDefinition GetByKeyType(KeyType type)
         /// <exception cref="InvalidOperationException">
         /// When the curve type is not supported.
         /// </exception>
-        public static KeyDefinition GetByCoseCurveType(CoseEcCurve curve) =>
+        public static KeyDefinition GetByCoseCurve(CoseEcCurve curve) =>
              _allDefinitions.Values.SingleOrDefault(
                 d => d.CoseKeyDefinition != null && d.CoseKeyDefinition.CurveIdentifier == curve)
                 ?? throw new InvalidOperationException(

Yubico.YubiKey/src/Yubico/YubiKey/Fido2/Cose/CoseEcPublicKey.cs

@@ -152,7 +152,7 @@ private CoseEcPublicKey()
         /// </exception>
         public CoseEcPublicKey(CoseEcCurve curve, ReadOnlyMemory<byte> xCoordinate, ReadOnlyMemory<byte> yCoordinate)
         {
-            var keyDefinition = KeyDefinitions.GetByCoseCurveType(curve) ??
+            var keyDefinition = KeyDefinitions.GetByCoseCurve(curve) ??
                 throw new ArgumentException(nameof(curve), "Unknown curve");
 
             var coseDefinition = keyDefinition.CoseKeyDefinition ??
@@ -266,7 +266,7 @@ public CoseEcPublicKey(ECParameters ecParameters)
         /// </returns>
         public ECParameters ToEcParameters()
         {
-            var definition = KeyDefinitions.GetByCoseCurveType(_curve);
+            var definition = KeyDefinitions.GetByCoseCurve(_curve);
 
             var ecParams = new ECParameters
             {

Yubico.YubiKey/tests/unit/Yubico/YubiKey/Cryptography/KeyDefinitionsTests.cs

@@ -30,8 +30,8 @@ public void GetByKeyType_InvalidType_ThrowsException()
         public void GetByCoseCurveType_ValidCurves_ReturnsCorrectDefinitions()
         {
             // Act & Assert
-            Assert.Equal(KeyDefinitions.P256, KeyDefinitions.GetByCoseCurveType(CoseEcCurve.P256));
-            Assert.Equal(KeyDefinitions.Ed25519, KeyDefinitions.GetByCoseCurveType(CoseEcCurve.Ed25519));
+            Assert.Equal(KeyDefinitions.P256, KeyDefinitions.GetByCoseCurve(CoseEcCurve.P256));
+            Assert.Equal(KeyDefinitions.Ed25519, KeyDefinitions.GetByCoseCurve(CoseEcCurve.Ed25519));
         }
 
         [Fact]
@@ -41,7 +41,7 @@ public void GetByCoseCurveType_InvalidCurve_ThrowsException()
             CoseEcCurve invalidCurve = (CoseEcCurve)999;
 
             // Act & Assert
-            Assert.Throws<InvalidOperationException>(() => KeyDefinitions.GetByCoseCurveType(invalidCurve));
+            Assert.Throws<InvalidOperationException>(() => KeyDefinitions.GetByCoseCurve(invalidCurve));
         }
 
         [Fact]