Dennisdyallo/hid share mode

Yubico.Core/src/Yubico/Core/CoreCompatSwitches.cs

@@ -25,5 +25,11 @@ public static class CoreCompatSwitches
         /// Default is false / shared.
         /// </summary>
         public const string OpenSmartCardHandlesExclusively = nameof(OpenSmartCardHandlesExclusively);
+
+        /// <summary>
+        /// If set to true, Yubico.Core will attempt to open HID handles exclusively. False will open shared.
+        /// Default is false / shared.
+        /// </summary>
+        public const string OpenHidHandlesExclusively = nameof(OpenHidHandlesExclusively);
     }
 }

Yubico.Core/src/Yubico/Core/Devices/Hid/MacOSHidIOReportConnection.cs

@@ -121,7 +121,14 @@ private void SetupConnection()
                     throw new PlatformApiException(ExceptionMessages.IOKitCannotOpenDevice);
                 }
 
-                int result = IOHIDDeviceOpen(_deviceHandle, 0x01);
+                int shareMode = 
+                    AppContext.TryGetSwitch(
+                        CoreCompatSwitches.OpenHidHandlesExclusively, 
+                        out bool isEnabled) && isEnabled
+                        ? IOKitHidConstants.kIOHIDOptionsTypeSeizeDevice
+                        : IOKitHidConstants.kIOHIDOptionsTypeNone;
+
+                int result = IOHIDDeviceOpen(_deviceHandle, shareMode);
                 _log.IOKitApiCall(nameof(IOHIDDeviceOpen), (kern_return_t)result);
 
                 if (result != 0)

Yubico.Core/src/Yubico/Core/Devices/Hid/WindowsHidFeatureReportConnection.cs

@@ -21,29 +21,30 @@ internal sealed class WindowsHidFeatureReportConnection : IHidConnection
     {
         // The SDK device instance that created this connection instance.
         private readonly WindowsHidDevice _device;
+
         // The underlying Windows HID device used for communication.
-        private IHidDDevice HidDDevice { get; set; }
+        private readonly HidDDevice _hidDDevice;
 
         public int InputReportSize { get; private set; }
         public int OutputReportSize { get; private set; }
 
         internal WindowsHidFeatureReportConnection(WindowsHidDevice device, string path)
         {
             _device = device;
-            HidDDevice = new HidDDevice(path);
+            _hidDDevice = new HidDDevice(path);
             SetupConnection();
         }
 
         private void SetupConnection()
         {
-            HidDDevice.OpenFeatureConnection();
-            InputReportSize = HidDDevice.FeatureReportByteLength;
-            OutputReportSize = HidDDevice.FeatureReportByteLength;
+            _hidDDevice.OpenFeatureConnection();
+            InputReportSize = _hidDDevice.FeatureReportByteLength;
+            OutputReportSize = _hidDDevice.FeatureReportByteLength;
         }
 
         public byte[] GetReport()
         {
-            byte[] data = HidDDevice.GetFeatureReport();
+            byte[] data = _hidDDevice.GetFeatureReport();
 
             _device.LogDeviceAccessTime();
 
@@ -52,23 +53,23 @@ public byte[] GetReport()
 
         public void SetReport(byte[] report)
         {
-            HidDDevice.SetFeatureReport(report);
+            _hidDDevice.SetFeatureReport(report);
             _device.LogDeviceAccessTime();
         }
 
         #region IDisposable Support
-        private bool disposedValue; // To detect redundant calls
+        private bool _disposedValue; // To detect redundant calls
 
         private void Dispose(bool disposing)
         {
-            if (!disposedValue)
+            if (!_disposedValue)
             {
                 if (disposing)
                 {
-                    HidDDevice.Dispose();
+                    _hidDDevice.Dispose();
                 }
 
-                disposedValue = true;
+                _disposedValue = true;
             }
         }
 

Yubico.Core/src/Yubico/Core/Devices/SmartCard/DesktopSmartCardDevice.cs

@@ -131,13 +131,12 @@ public override ISmartCardConnection Connect()
 
             try
             {
-                SCARD_SHARE shareMode = SCARD_SHARE.SHARED;
-
-                if (AppContext.TryGetSwitch(CoreCompatSwitches.OpenSmartCardHandlesExclusively, out bool enabled) &&
-                    enabled)
-                {
-                    shareMode = SCARD_SHARE.EXCLUSIVE;
-                }
+                SCARD_SHARE shareMode = 
+                    AppContext.TryGetSwitch(
+                            CoreCompatSwitches.OpenSmartCardHandlesExclusively, 
+                            out bool isEnabled) && isEnabled
+                        ? SCARD_SHARE.EXCLUSIVE
+                        : SCARD_SHARE.SHARED;
 
                 result = SCardConnect(
                     context,

Yubico.Core/src/Yubico/PlatformInterop/macOS/IOKitFramework/IOKitHidConstants.cs

@@ -27,5 +27,20 @@ internal static class IOKitHidConstants
         public const int kIOHidReportTypeInput = 0;
         public const int kIOHidReportTypeOutput = 1;
         public const int kIOHidReportTypeFeature = 2;
+
+        /// <summary>
+        /// No options specified.
+        /// </summary>
+        public const int kIOHIDOptionsTypeNone = 0x00;
+
+        /// <summary>
+        /// Seize the device, preventing other applications from accessing it.
+        /// </summary>
+        public const int kIOHIDOptionsTypeSeizeDevice = 0x01;
+
+        /// <summary>
+        /// Ignore the device, preventing it from being opened.
+        /// </summary>
+        public const int kIOHIDOptionsTypeIgnore = 0x02;
     }
 }