Simplify screenshot capture and add support for wayland#1053
Simplify screenshot capture and add support for wayland#1053evan-a-a wants to merge 1 commit intoYubico:mainfrom
Conversation
7360348 to
50f390c
Compare
50f390c to
c3dc2d0
Compare
pyscreenshot supports capturing screenshots via numerous backends and can automatically select the best one depending on platform. This enables capturing of the QR code on wayland-based desktops while maintaining support for Windows and X11
c3dc2d0 to
0e23fba
Compare
|
This should be working now, at least on Linux. I'll give it a checkout on Windows once the test build is done. I don't have a macOS machine available to test. Small note, I tested this in the Flatpak but there's a small bug in |
|
Hi, and thanks for the PR! |
|
I tested merging this (+ resolving conflicts) with latest Upstream bug report is here: GNOME/gnome-screenshot#201. (It was closed as "Won't Fix", given the dependency on non-Wayland compositor + Gnome Shell). So, if GNOME devs are not interested in fixing this for Wayland, that leaves some other options. Not sure about what might be going on with the spinner issue on Windows' side. |
|
Guys, just use portals for Wayland. It's generally impossible to implement a universal screenshot tool for Wayland without using something like portals, thanks to Wayland protocol. GNOME devs physically can't fix that issue. Also screenshoters for Sway (that uses Documentation for the portal you need: https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.Screenshot |
|
The same could be done for #1399 The current thing just uses an |
pyscreenshot supports capturing screenshots via numerous backends and can automatically select the best one depending on platform. This enables capturing of the QR code on wayland-based desktops while maintaining support for Windows and X11 desktops.
Fixes #1010