Improve CI: Add PR builds and fix vultr-types dependency error#9
Merged
Improve CI: Add PR builds and fix vultr-types dependency error#9
Conversation
Co-authored-by: Yukaii <4230968+Yukaii@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve CI
Improve CI: Add PR builds and fix vultr-types dependency error
Jun 5, 2025
Owner
|
Co-authored-by: Yukaii <4230968+Yukaii@users.noreply.github.com>
Contributor
Author
|
... Fixed the E2E test failure! The issue was that the Changes made:
E2E tests now pass completely: ea0aa46 |
Owner
|
@copilot This step keep failing on github action |
Co-authored-by: Yukaii <4230968+Yukaii@users.noreply.github.com>
Contributor
Author
... Fixed the CI build failure! The issue was that my previous commit removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the CI improvements requested in the issue by adding a CI workflow for pull requests and fixing the build error that was occurring in the publish action.
Changes Made
1. Added CI Workflow for Pull Requests
.github/workflows/ci.ymlthat runs on both PR opens and main branch pushes2. Fixed vultr-types Build Error
The original error was:
Root Cause: The
tailportalpackage was importing fromvultr-typesbut didn't declare it as a dependency, causing esbuild to fail during bundling in CI environments.Solution:
0.1.0) tovultr-typespackage.jsonvultr-types: "workspace:*"as dependency in tailportal package.json--external:vultr-typesto esbuild config to mark it as external moduleThis approach ensures vultr-types is available at runtime while being excluded from the bundle, resolving the build error without changing the application logic.
3. Verification
The fix ensures the publish action can successfully build packages while maintaining the workspace dependency structure.
Fixes #8.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.