First ldap implementation

[yalh76]

Problem

• Fix Integrate LDAP support (now supported by Pixelfed) #171

Solution

• First ldap implementation

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[yalh76]

!testme

[yunohost-bot]

Fingers crossed!

[lapineige]

Thank you for working on this !

This will need quite a lot of testing, for both new and existing installations.

[yalh76]

!testme

[yunohost-bot]

Alrighty!

[lapineige]

This will need a lot of testing I guess (creating/removing user account, migrating from old Pixelfed without LDAP account, …).
I have no test server for that, so if anyone is willing to do it…

[yalh76]

!testme

[yunohost-bot]

Meow 🐈

[lapineige]

Ok, I'm not sure that including php fix is the best thing here, but let's do it your way ;)
At least CI will be happy :D

[yalh76]

well as we already upgraded pixelfed to php7.4, I don't think we will have more issues

[lapineige]

LGTM, but we need manual testing

[yalh76]

!testme

[yunohost-bot]

May the CI gods be with you!

[yalh76]

!testme

[yunohost-bot]

✌️

[yalh76]

!testme

[yunohost-bot]

🎠

[lapineige]

!testme

[yunohost-bot]

😜

[lapineige]

1030018 INFO DEBUG -   - Installing spatie/db-dumper (2.21.1): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/laravel-backup (6.16.5): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/image-optimizer (1.6.2): Extracting archive
1030019 INFO DEBUG -   - Installing spatie/laravel-image-optimizer (1.6.4): Extracting archive
1030020 INFO DEBUG -   - Installing ezyang/htmlpurifier (v4.16.0): Extracting archive
1030020 INFO DEBUG -   - Installing stevebauman/purify (v3.0.3): Extracting archive
1030020 INFO DEBUG - Package swiftmailer/swiftmailer is abandoned, you should avoid using it. Use symfony/mailer instead.
1030021 INFO DEBUG - Generating optimized autoload files
1030021 INFO DEBUG - > Illuminate\Foundation\ComposerScripts::postAutoloadDump
1030021 INFO DEBUG - > @php artisan package:discover --ansi
1030022 INFO DEBUG -
1030022 INFO DEBUG - In User.php line 14:
1030022 INFO DEBUG -
1030023 INFO DEBUG -   Interface "LdapRecord\Laravel\Auth\LdapAuthenticatable" not found
1030024 INFO DEBUG -
1030025 INFO DEBUG -
1030025 INFO DEBUG - Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1
1030025 INFO DEBUG - + ynh_die '--message=Unable to install core dependencies with Composer.'

Sounds bad 😅

[ericgaspar]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

Living in the past, are we? 🐮👁️

[yalh76]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

Living in the past, are we? 🐮👁️

[lapineige]

Looking god. I would like some manual testing. If someone want to try… :)