This repository was archived by the owner on Oct 19, 2024. It is now read-only.
Update .collection() method to work with multiple dbs#22
Open
ShishKabab wants to merge 1 commit intoYurySolovyov:masterfrom
Open
Update .collection() method to work with multiple dbs#22ShishKabab wants to merge 1 commit intoYurySolovyov:masterfrom
.collection() method to work with multiple dbs#22ShishKabab wants to merge 1 commit intoYurySolovyov:masterfrom
Conversation
By using the `db` parameter passed in by Dexie when constructing a new instance, every time a new instance is created, the `collection` method works only on the latest DB. This breaks use cases such as ours when testing multi-device sync, creating a `backend` DB and multiple `client` DBs.
Owner
|
Can you please add a test? |
Author
|
That'd take a bit more time, but I'll see if I can find it soon-ish :) |
Owner
|
Sure, no rush |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using the
dbparameter passed in by Dexie when constructing a new instance, every time a new instance is created, thecollectionmethod works only on the latest DB. This breaks use cases such as ours when testing multi-device sync, creating abackendDB and multipleclientDBs.