Add static linkage to file-local function#8521
Merged
NikolajBjorner merged 3 commits intomasterfrom Feb 7, 2026
Merged
Conversation
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add static linkage to file-local functions
Add static linkage to file-local functions
Feb 6, 2026
nunoplopes
reviewed
Feb 7, 2026
src/ast/ast.cpp
Outdated
| // show an expr_ref on stdout | ||
|
|
||
| void prexpr(expr_ref &e){ | ||
| static void prexpr(expr_ref &e){ |
Collaborator
There was a problem hiding this comment.
@copilot revert this one. It should always be available for debugging. Maybe define it only in debugging mode.
Contributor
Author
There was a problem hiding this comment.
Reverted in eced186. The prexpr function is now non-static and remains available for debugging.
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Copilot
AI
changed the title
Add static linkage to file-local functions
Add static linkage to file-local function
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One function was defined at file scope but only used within its compilation unit, violating encapsulation and unnecessarily exposing symbols.
Changes
throw_invalid_reference()insrc/api/z3_replayer.cpp- internal error handling helperThis function now has static linkage, properly scoping it to its translation unit.
Notes
Initially identified
SetR,SetO,SetAOinapi_log.cppas candidates, but these are declared in the generated headerapi_log_macros.hand must remain externally visible.The
prexpr()function insrc/ast/ast.cppwas initially changed but has been reverted to remain available for debugging purposes across the codebase.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.