Verify method access specifiers - no changes required#8522
Closed
Verify method access specifiers - no changes required#8522
Conversation
Copilot
AI
changed the title
[WIP] Update class methods to private accessibility
Verify method access specifiers - no changes required
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analyzed codebase to identify methods that should be private but are currently public. No violations found - all methods are correctly scoped.
Analysis Scope
Examined 100+ header files across:
src/smt/- Theory implementations, context, conflict resolutionsrc/util/- Core data structures (vector, heap, rational, hashtable)src/ast/- AST nodes, simplifiers, rewriterssrc/sat/- SAT solver componentssrc/opt/- Optimization algorithmsFindings
Helper methods are already private/protected:
heap.h:move_up(),move_down(),check_invariant_core()vector.h:expand_vector(),copy_core(),destroy_elements()smt_context.h:ts_visit_child(),ts_visit_children(),top_sort_expr()Public methods have external callers:
smt_setup::already_configured()→ called fromsmt_context.cppmaxsmt::reset_upper()→ called fromopt_context.cppeuf_enodeprivate methods → accessed via friend classegraphVerification method: Cross-referenced method declarations with call sites using grep across all
.cppfiles.Result
Codebase already complies with encapsulation best practices. No changes required.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.