Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

Use translation key instead of config for navigation group#143

Open
RawanD201 wants to merge 1 commit intoZ3d0X:mainfrom
RawanD201:fix/navigation-group-translation
Open

Use translation key instead of config for navigation group#143
RawanD201 wants to merge 1 commit intoZ3d0X:mainfrom
RawanD201:fix/navigation-group-translation

Conversation

@RawanD201
Copy link
Copy Markdown

feat: replace config-based navigation group with translation key

  • Use __('filament-logger::filament-logger.nav.group') instead of config lookup
  • Improves multi-language support following Laravel conventions
  • Maintains backward compatibility with existing translations

Copy link
Copy Markdown

@aspirantzhang aspirantzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I recommend merging this PR.

@aspirantzhang
Copy link
Copy Markdown

@RawanD201
#146

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants